Re: [RFCv3 1/2] gitweb: add patch view

[Petr Baudis <pasky@suse.cz>]

On Sat, Dec 06, 2008 at 02:01:09PM +0100, Giuseppe Bilotta wrote:
> On Sat, Dec 6, 2008 at 1:46 AM, Junio C Hamano <gitster@pobox.com> wrote:
> > Some things, like sitewide default css changes, cannot be made disabled
> > by default.  But a new feature can easily be kept disabled by default not
> > to cause needless surprises.
> 
> In the eternal war between making feature easily available and not
> disturbing the user too much between upgrades, I'm more on the 'making
> available' field, especially when the features are not particularly
> invasive (e.g., the patch view only adds one single link, on the
> navigation bar, and only in some views).
> 
> It should also be noted that if the sysadmin deploys a new software
> version without telling its users, there's an obvious communication
> problem between the sysadmin and its users, but that's not something
> the tool developers should try to work around. Otherwise we'd still be
> offering the dash version of the commands by default.

I feel exactly the same.

Acked-by: Petr Baudis <pasky@suse.cz>

Same goes for the patches, I haven't had time to examine them in detail
but the general shape looks fine.