* [PATCH] Let git remote accept up as alias to update
@ 2008-12-13 18:18 Alexey Zaytsev
2008-12-14 11:25 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Zaytsev @ 2008-12-13 18:18 UTC (permalink / raw)
To: git
Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
---
Don't know why, but I keep typing remote up instead of
remote update. As update is probably by far the most
used remote action, can we please have this alias?
builtin-remote.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index abc8dd8..8f5cd6d 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -893,7 +893,7 @@ int cmd_remote(int argc, const char **argv, const char *prefix)
result = show(argc, argv);
else if (!strcmp(argv[0], "prune"))
result = prune(argc, argv);
- else if (!strcmp(argv[0], "update"))
+ else if (!strcmp(argv[0], "update") || !strcmp(argv[0], "up"))
result = update(argc, argv);
else {
error("Unknown subcommand: %s", argv[0]);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Let git remote accept up as alias to update
2008-12-13 18:18 [PATCH] Let git remote accept up as alias to update Alexey Zaytsev
@ 2008-12-14 11:25 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2008-12-14 11:25 UTC (permalink / raw)
To: Alexey Zaytsev; +Cc: git
On Sat, Dec 13, 2008 at 09:18:56PM +0300, Alexey Zaytsev wrote:
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
> ---
>
> Don't know why, but I keep typing remote up instead of
> remote update. As update is probably by far the most
> used remote action, can we please have this alias?
Hmm. The usual answer for requests like this is "make your own alias".
But usually they are for primary command aliases (e.g., "co" for
"checkout"), and this is a sub-command. So you are actually stuck doing:
git config alias.rup "remote update"
which is maybe better (even less typing) but is not exactly what you
asked for.
I think even nicer than an explicit "up" alias would be to accept any
prefix as long as it was unique. However, I think a scheme like that
would only make sense if it was used fairly universally, and the current
code is not amenable to doing it for regular commands (it doesn't
actually have a complete list of commands -- it just tries to exec what
you tell it). However, it could be refactored to do so.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-14 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-13 18:18 [PATCH] Let git remote accept up as alias to update Alexey Zaytsev
2008-12-14 11:25 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).