From: Jeff King <peff@peff.net>
To: Nicolas Pitre <nico@cam.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] pack-objects: don't use too many threads with few objects
Date: Sat, 13 Dec 2008 21:20:26 -0500 [thread overview]
Message-ID: <20081214022025.GA22571@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.LFD.2.00.0812131456040.30035@xanadu.home>
On Sat, Dec 13, 2008 at 03:06:40PM -0500, Nicolas Pitre wrote:
> If there are few objects to deltify, they might be split amongst threads
> so that there is simply no other objects left to delta against within
> the same thread. Let's use the same 2*window treshold as used for the
> final load balancing to allow extra threads to be created.
>
> This fixes the benign t5300 test failure.
I can confirm this fixes my t5300 failure. Thanks.
Tested-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2008-12-14 2:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 20:36 [PATCH] autodetect number of CPUs by default when using threads Nicolas Pitre
2008-12-11 22:25 ` Junio C Hamano
2008-12-12 0:55 ` Nicolas Pitre
2008-12-13 13:32 ` Jeff King
2008-12-13 19:27 ` Nicolas Pitre
2008-12-13 20:06 ` [PATCH] pack-objects: don't use too many threads with few objects Nicolas Pitre
2008-12-14 2:20 ` Jeff King [this message]
2008-12-15 18:38 ` Mike Ralphson
2008-12-16 1:15 ` Junio C Hamano
2008-12-16 3:20 ` Jeff King
2008-12-16 5:21 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081214022025.GA22571@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).