From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Markus Heidelberg <markus.heidelberg@web.de>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] bash completion: remove deprecated --prune from git-gc
Date: Sun, 14 Dec 2008 06:19:39 -0500 [thread overview]
Message-ID: <20081214111939.GC6499@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0812141216120.2014@eeepc-johanness>
On Sun, Dec 14, 2008 at 12:17:07PM +0100, Johannes Schindelin wrote:
> > Which annoyingly has no discussion about _why_ it no longer has an
> > effect. But I suspect it has something to do with 25ee973 (gc: call
> > "prune --expire 2.weeks.ago" by default, 2008-03-12) by you.
>
> Oops.
>
> But I thought that git gc --prune does expire _all_ dangling loose
> objects _now_, not with --expire 2.weeks.ago.
Nope, see 25ee973. You explicitly wrote:
Note that this new behaviour makes "--prune" be a no-op.
That being said, I think that is perhaps a reasonable thing for --prune
to do (and I don't think there is any conflict with the name, because
that is what it _used_ to do before becoming a no-op). But nobody has
actually implemented it.
-Peff
next prev parent reply other threads:[~2008-12-14 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 19:08 [PATCH] bash completion: remove deprecated --prune from git-gc Markus Heidelberg
2008-12-14 10:38 ` Johannes Schindelin
2008-12-14 11:12 ` Jeff King
2008-12-14 11:17 ` Johannes Schindelin
2008-12-14 11:19 ` Jeff King [this message]
2008-12-15 18:06 ` Brandon Casey
2008-12-15 16:51 ` Brandon Casey
2008-12-14 11:23 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081214111939.GC6499@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=markus.heidelberg@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).