From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Boyd Stephen Smith Jr." <bss03@volumehost.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: fatal output from git-show really wants a terminal
Date: Mon, 15 Dec 2008 03:25:15 -0500 [thread overview]
Message-ID: <20081215082514.GA32123@coredump.intra.peff.net> (raw)
In-Reply-To: <7v3agpzwet.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 15, 2008 at 12:15:38AM -0800, Junio C Hamano wrote:
> I haven't heard anything more about this, but if you were indeed
> discussing the change made by 61b8050, I think the fix should just be like
> this.
> [...]
> - dup2(pager_process.in, 2);
> + if (isatty(2))
> + dup2(pager_process.in, 2);
I can't speak for the original poster, but I do think this behavior
should be less surprising to users who perform the one particular
redirection (and in the other 99% of cases, should behave exactly the
same). So I think it's a positive change.
-Peff
prev parent reply other threads:[~2008-12-15 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 16:01 fatal output from git-show really wants a terminal Tim Olsen
2008-12-10 16:10 ` Boyd Stephen Smith Jr.
2008-12-10 19:46 ` Johannes Sixt
2008-12-10 20:10 ` Tim Olsen
2008-12-10 22:24 ` Boyd Stephen Smith Jr.
[not found] ` <alpine.DEB.1.00.0812111015140.18321@eeepc-johanness>
2008-12-11 16:51 ` Boyd Stephen Smith Jr.
2008-12-11 21:55 ` Jeff King
2008-12-11 22:45 ` Boyd Stephen Smith Jr.
2008-12-11 22:59 ` Jeff King
2008-12-11 23:03 ` Junio C Hamano
2008-12-15 8:15 ` Junio C Hamano
2008-12-15 8:23 ` Junio C Hamano
2008-12-15 8:25 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215082514.GA32123@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=bss03@volumehost.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).