From: Jeff King <peff@peff.net>
To: jidanni@jidanni.org
Cc: git@vger.kernel.org
Subject: Re: git-diff should not fire up $PAGER, period!
Date: Wed, 17 Dec 2008 22:31:16 -0500 [thread overview]
Message-ID: <20081218033116.GC20749@coredump.intra.peff.net> (raw)
In-Reply-To: <8763lixyps.fsf_-_@jidanni.org>
On Thu, Dec 18, 2008 at 05:45:35AM +0800, jidanni@jidanni.org wrote:
> Gentlemen, I have found the solution to your problem.
>
> Unbundle git-diff and $PAGER.
If you are going to argue this, please at least go back and read the
numerous times it has been brought up in the past on the list archive.
The last discussion ended up showing that some people really like the
automatic pager for some commands, and some people really detest it.
So I implemented 4e10738 (Allow per-command pager config, 2008-07-03),
and now you can do:
git config pager.diff false
and be happy (or, as you obviously disocvered, simply unsetting
core.pager will disable all).
-Peff
next prev parent reply other threads:[~2008-12-18 3:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 0:21 git-diff should not fire up $PAGER if there is no diff jidanni
2008-12-16 0:56 ` Jeff King
2008-12-16 6:35 ` Stefan Karpinski
2008-12-16 7:44 ` Jeff King
2008-12-16 22:43 ` Stefan Karpinski
2008-12-17 21:45 ` git-diff should not fire up $PAGER, period! jidanni
2008-12-17 22:02 ` Junio C Hamano
2008-12-17 22:04 ` Linus Torvalds
2008-12-22 3:28 ` Miles Bader
2008-12-18 3:31 ` Jeff King [this message]
2008-12-22 3:27 ` Miles Bader
2008-12-22 7:55 ` Johannes Sixt
2008-12-22 8:30 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2008-12-18 2:18 Mike Coleman
2008-12-18 2:26 ` Junio C Hamano
2008-12-18 3:22 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218033116.GC20749@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).