git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Vajna <vmiklos@frugalware.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, scott@canonical.com
Subject: git-fast-export and tags without a tagger
Date: Thu, 18 Dec 2008 17:46:14 +0100	[thread overview]
Message-ID: <20081218164614.GS5691@genesis.frugalware.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

Hi,

Tags created with ancient versions of git have no tagger. The udev repo
has such tags, for example:

$ git cat-file tag 4ea98ca6db3b84f5bc16eac8574e5c209ec823ce
object face198a5f21027fefe796dc01e19e349a2d36ce
type commit
tag 062

fast-export will fail on these repos. From IRC:

20:05 < Keybuk> vmiklos: exactly the same error with 1.6.0.5
20:07 < Keybuk> $ git fast-export --signed-tag=strip --all
20:07 < Keybuk> fatal: No tagger for tag 4ea98ca6db3b84f5bc16eac8574e5c209ec823ce

I think it would be nice to handle the situation better than just die().

What about a --force option that would fake the tagger in case the tag
points to a commmit and use the commiter from there?

I'm willing to work on this, but I thought it's better to discuss the
right solution for the problem first.

Thanks.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2008-12-18 16:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-18 16:46 Miklos Vajna [this message]
2008-12-18 19:15 ` git-fast-export and tags without a tagger Junio C Hamano
2008-12-18 19:45   ` [PATCH] fast-export: deal with tag objects that do not have " Johannes Schindelin
2008-12-18 21:34     ` Miklos Vajna
2008-12-18 23:20       ` Junio C Hamano
2008-12-18 23:38         ` Miklos Vajna
2008-12-20  0:00         ` [PATCH v2] " Johannes Schindelin
2008-12-20  0:33           ` [PATCH] fast-import: make tagger information optional Junio C Hamano
2008-12-20  0:59             ` Miklos Vajna
2008-12-20  0:59             ` Shawn O. Pearce
2008-12-18 21:36   ` git-fast-export and tags without a tagger Miklos Vajna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081218164614.GS5691@genesis.frugalware.org \
    --to=vmiklos@frugalware.org \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=scott@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).