From: Miklos Vajna <vmiklos@frugalware.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org, scott@canonical.com
Subject: Re: [PATCH] fast-export: deal with tag objects that do not have a tagger
Date: Fri, 19 Dec 2008 00:38:43 +0100 [thread overview]
Message-ID: <20081218233843.GA21154@genesis.frugalware.org> (raw)
In-Reply-To: <7viqphf4ua.fsf@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Thu, Dec 18, 2008 at 03:20:29PM -0800, Junio C Hamano <gitster@pobox.com> wrote:
> Such a "faking" can well be done, and should be done, on the consuming end
> of the information. If you fake using the commit authorship, you would
> never be able to tell from the result which one is faked and which one is
> genuine.
>
> I think you'd rather want to see "Unspecified Tagger" in the resulting tag
> object (or even better, a tag object without the tagger field created by
> the fast-import process), and leave the interpretation of missing tagger
> information to the consumers.
Aah, I missed that Dscho's patch will not just not die(), but it _will_
output a stream that fast-import will import. So just forget my
complain. :-)
And Dscho, thanks!
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-12-18 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 16:46 git-fast-export and tags without a tagger Miklos Vajna
2008-12-18 19:15 ` Junio C Hamano
2008-12-18 19:45 ` [PATCH] fast-export: deal with tag objects that do not have " Johannes Schindelin
2008-12-18 21:34 ` Miklos Vajna
2008-12-18 23:20 ` Junio C Hamano
2008-12-18 23:38 ` Miklos Vajna [this message]
2008-12-20 0:00 ` [PATCH v2] " Johannes Schindelin
2008-12-20 0:33 ` [PATCH] fast-import: make tagger information optional Junio C Hamano
2008-12-20 0:59 ` Miklos Vajna
2008-12-20 0:59 ` Shawn O. Pearce
2008-12-18 21:36 ` git-fast-export and tags without a tagger Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218233843.GA21154@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=scott@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).