git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Burton <markb@ordern.com>
To: git@vger.kernel.org
Subject: RFC: Change whatchanged to report changes from merges by default?
Date: Sat, 20 Dec 2008 10:42:32 +0000	[thread overview]
Message-ID: <20081220104232.5ff1b7c0@crow> (raw)


Hi,

Is it just an accident of history or by design that whatchanged
requires the -m option to show changes introduced by merges but
diff and git log show those changes without requiring any extra
options?

Would it not make more sense to have git whatchanged show the changes
introduced by merges by default and then people can use the (already
supported) --no-merges option to suppress that behaviour?

It appears that just setting rev.ignore_merges to 0 in cmd_whatchanged()
would do the trick. Shall I submit a patch?

Mark

             reply	other threads:[~2008-12-20 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-20 10:42 Mark Burton [this message]
2008-12-20 17:22 ` RFC: Change whatchanged to report changes from merges by default? Mark Burton
2008-12-20 20:09 ` Junio C Hamano
2008-12-20 20:21   ` Mark Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081220104232.5ff1b7c0@crow \
    --to=markb@ordern.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).