From: Mark Burton <markb@ordern.com>
To: git@vger.kernel.org
Subject: Re: RFC: Change whatchanged to report changes from merges by default?
Date: Sat, 20 Dec 2008 17:22:52 +0000 [thread overview]
Message-ID: <20081220172252.6469d9b7@crow> (raw)
In-Reply-To: <20081220104232.5ff1b7c0@crow>
Hi,
On further studying, I see that 1aec7917dc (git log: don't do merge
diffs by default) makes git log only show the log message by default
for merges. OK, no problem with that.
However, in my mind, whatchanged is misleading when it doesn't output
anything (by default) for merges because, in my mind, that implies that
nothing has changed when, in fact, whole heaps of stuff could have been
merged in. So, if you forget to add the -m option, whatchanged will silently
ignore all the merged stuff and leave the poor user in the dark.
So, if changing the default behaviour is acceptable, I still think it would
be better if ignore_merges is set to 0 in cmd_whatchanged() but I guess an
alternative would be to set always_show_header, instead.
Any thoughts?
Cheers,
Mark
next prev parent reply other threads:[~2008-12-20 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-20 10:42 RFC: Change whatchanged to report changes from merges by default? Mark Burton
2008-12-20 17:22 ` Mark Burton [this message]
2008-12-20 20:09 ` Junio C Hamano
2008-12-20 20:21 ` Mark Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081220172252.6469d9b7@crow \
--to=markb@ordern.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).