From: "Shawn O. Pearce" <spearce@spearce.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] fast-import: add special mode; copy from parent.
Date: Sun, 21 Dec 2008 14:07:57 -0800 [thread overview]
Message-ID: <20081221220757.GA17355@spearce.org> (raw)
In-Reply-To: <1229825502-963-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> wrote:
> + if (!prefixcmp(p, "- ")) {
> + mode = 0;
> + p += 2;
This part made me wonder, why are we always doing "S_IFREG | mode"
further down?
> + } else {
> + p = get_mode(p, &mode);
> + if (!p)
> + die("Corrupt mode: %s", command_buf.buf);
> + switch (mode) {
> + case S_IFREG | 0644:
> + case S_IFREG | 0755:
> + case S_IFLNK:
> + case S_IFGITLINK:
> + case 0644:
> + case 0755:
> + /* ok */
> + break;
> + default:
> + die("Corrupt mode: %s", command_buf.buf);
> + }
--
Shawn.
next prev parent reply other threads:[~2008-12-21 22:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 2:11 [PATCH 1/2] fast-import: add special mode; copy from parent Felipe Contreras
2008-12-21 2:11 ` [PATCH 2/2] fast-import: add special '-' blob reference to use the previous one Felipe Contreras
2008-12-21 22:11 ` Shawn O. Pearce
2008-12-21 22:24 ` Junio C Hamano
2008-12-21 22:33 ` Shawn O. Pearce
2008-12-22 2:10 ` Felipe Contreras
2008-12-22 2:08 ` Felipe Contreras
2008-12-21 22:07 ` Shawn O. Pearce [this message]
2008-12-22 2:23 ` [PATCH 1/2] fast-import: add special mode; copy from parent Felipe Contreras
2008-12-22 2:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081221220757.GA17355@spearce.org \
--to=spearce@spearce.org \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).