From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH 11/23] Rewrite WindowCache to use a hash table
Date: Sat, 27 Dec 2008 14:30:05 +0100 [thread overview]
Message-ID: <200812271430.06052.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1230171079-17156-12-git-send-email-spearce@spearce.org>
torsdag 25 december 2008 03:11:07 skrev Shawn O. Pearce:
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> index f617845..f478f04 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> @@ -41,11 +41,7 @@
> import java.io.IOException;
> import java.lang.ref.ReferenceQueue;
>
> -/**
> - * The WindowCache manages reusable <code>Windows</code> and inflaters used by
> - * the other windowed file access classes.
> - */
> -public class WindowCache {
> +class WindowCache {
This breaks the Eclipse plugin which want to call WindowCache.reconfigure. Package level
class can also have javadocs. Even though we do not require it, I still thinks it's a good idea. Not
sure how useful that one was.
-- robin
next prev parent reply other threads:[~2008-12-27 13:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 2:10 [JGIT PATCH 00/18] Misc. performance tweaks Shawn O. Pearce
2008-12-25 2:10 ` [JGIT PATCH 01/23] Improve hit performance on the UnpackedObjectCache Shawn O. Pearce
2008-12-25 2:10 ` [JGIT PATCH 02/23] Add MutableObjectId.clear() to set the id to zeroId Shawn O. Pearce
2008-12-25 2:10 ` [JGIT PATCH 03/23] Allow TreeWalk callers to pass a MutableObjectId to get the current id Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 04/23] Switch ObjectWalk to use the new MutableObjectId form in TreeWalk Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 05/23] Change walker based fetch to use TreeWalk's MutableObjectId accessor Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 06/23] Reduce garbage allocation when using TreeWalk Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 07/23] Switch ObjectWalk to use a naked CanonicalTreeParser because its faster Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 08/23] Remove the unused PackFile.get(ObjectId) form Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 09/23] Remove getId from ObjectLoader API as its unnecessary overhead Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 10/23] Make mmap mode more reliable by forcing GC at the correct spot Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 11/23] Rewrite WindowCache to use a hash table Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 12/23] Change ByteArrayWindow to read content outside of WindowCache's lock Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 13/23] Dispose of RevCommit buffers when they aren't used in PackWriter Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 14/23] Don't unpack delta chains while writing a pack from a pack v1 index Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 15/23] Don't unpack delta chains while converting delta to whole object Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 16/23] Defer parsing of the ObjectId while walking a PackIndex Iterator Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 17/23] Only do one getCachedBytes per whole object written Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 18/23] Correctly use a long for the offsets within a generated pack Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 19/23] Allow more direct access to determine isWritten Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 20/23] Move "wantWrite" field of ObjectToPack into the flags field Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 21/23] Use an ArrayList for the reuseLoader collection in PackWriter Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 22/23] Don't cut off existing delta chains if we are reusing deltas Shawn O. Pearce
2008-12-25 2:11 ` [JGIT PATCH 23/23] Correctly honor the thin parameter to PackWriter.writePack Shawn O. Pearce
2008-12-27 13:30 ` Robin Rosenberg [this message]
2008-12-27 17:32 ` [JGIT PATCH 11/23 v2] Rewrite WindowCache to use a hash table Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812271430.06052.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).