[PATCH] doc/git-send-email: mention sendemail.cc config variable

[PATCH] doc/git-send-email: mention sendemail.cc config variable

[Markus Heidelberg]

This variable was added in 5f8b9fc (git-send-email: add a new
sendemail.cc configuration variable, 2008-04-27), but is not yet refered
to by the documentation.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
 Documentation/git-send-email.txt |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index b69846e..ff4aeff 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -34,6 +34,7 @@ The --bcc option must be repeated for each user you want on the bcc list.
 
 --cc::
 	Specify a starting "Cc:" value for each email.
+	Default is the value of 'sendemail.cc'.
 +
 The --cc option must be repeated for each user you want on the cc list.
 
-- 
1.6.1.21.g0298

Re: [PATCH] doc/git-send-email: mention sendemail.cc config variable

[Thomas Rast]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

Markus Heidelberg wrote:
>  	Specify a starting "Cc:" value for each email.
> +	Default is the value of 'sendemail.cc'.
>  +
>  The --cc option must be repeated for each user you want on the cc list.

Judging from the source, this is not a default value that you can
override: any recipients listed in sendemail.cc configuration(s) are
always added to the Cc list.  The same goes for --bcc and
sendemail.bcc however, which uses the exact same formulation.

Maybe something like

  You can also add Cc recipients via 'sendemail.cc' configuration
  settings.

would clarify?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] doc/git-send-email: mention sendemail.cc config variable

[Markus Heidelberg]

Thomas Rast, 29.12.2008:
> Markus Heidelberg wrote:
> >  	Specify a starting "Cc:" value for each email.
> > +	Default is the value of 'sendemail.cc'.
> >  +
> >  The --cc option must be repeated for each user you want on the cc list.
> 
> Judging from the source, this is not a default value that you can
> override: any recipients listed in sendemail.cc configuration(s) are
> always added to the Cc list.  The same goes for --bcc and
> sendemail.bcc however, which uses the exact same formulation.

OK, and --to and sendemail.to is also affected.

> Maybe something like
> 
>   You can also add Cc recipients via 'sendemail.cc' configuration
>   settings.
> 
> would clarify?

It is already in next, I think a following patch should be against next
now, shouldn't it?

Markus

Re: [PATCH] doc/git-send-email: mention sendemail.cc config variable

[Junio C Hamano]

Markus Heidelberg <markus.heidelberg@web.de> writes:

> It is already in next, I think a following patch should be against next
> now, shouldn't it?

Surely, and thanks.

If you look at the output of

	$ git log --first-parent origin/master..origin/next

You will find the tip of mh/maint-sendmail-cc-doc topic branch is at
bd7c6e7 (doc/git-send-email: mention sendemail.cc config variable,
2008-12-29).  I'll apply any follow-up patch to the topic on top of that
commit, and then merge the result to 'next' (and 'master'/'maint' when the
result is ready).

In rare cases when there are other topics in 'next' that touch vicinity of
the code you are modifying, a patch made against 'next' may not apply
cleanly to the topic, but I'll wiggle it to apply anyway (that is what the
maintainers do), so it would certainly be nicer if you sent a patch to the
tip of the topic you are updating, but there is no need to worry about
such conflicts too much.

Re: [PATCH] doc/git-send-email: mention sendemail.cc config variable

[Markus Heidelberg]

Thomas Rast, 29.12.2008:
> Markus Heidelberg wrote:
> >  	Specify a starting "Cc:" value for each email.
> > +	Default is the value of 'sendemail.cc'.
> >  +
> >  The --cc option must be repeated for each user you want on the cc list.
> 
> Judging from the source, this is not a default value that you can
> override: any recipients listed in sendemail.cc configuration(s) are
> always added to the Cc list.  The same goes for --bcc and
> sendemail.bcc however, which uses the exact same formulation.

I just tested it with --dry-run: the command line options for all three
header lines (to cc bcc) override the corresponding config settings. So
the formulation is correct: the settings are only default values.

Markus

Re: [PATCH] doc/git-send-email: mention sendemail.cc config variable

[Thomas Rast]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Markus Heidelberg wrote:
> I just tested it with --dry-run: the command line options for all three
> header lines (to cc bcc) override the corresponding config settings. So
> the formulation is correct: the settings are only default values.

Indeed, you're right.  Apologies for the false alarm.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]