git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: skillzero@gmail.com
Cc: git@vger.kernel.org
Subject: Re: Why can't git pull --rebase work if there are modified files?
Date: Wed, 31 Dec 2008 00:09:09 +0100	[thread overview]
Message-ID: <200812310009.12052.trast@student.ethz.ch> (raw)
In-Reply-To: <2729632a0812301340y735c3946weee55c9856d4e6a9@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]

skillzero@gmail.com wrote:
> If I have locally modified files and I try to 'git pull --rebase', it
> fails because of the locally modified files. If I don't use the
> --rebase option, it works (but generates a merge commit if I have
> local commits). Why does rebasing require an unmodified checkout? It
> seems like it should only stop if I something in the newly fetched
> changes conflict with my local changes.

First you need to be aware that 'git pull --rebase' is conceptually
the same as 'git fetch && git rebase upstream', where 'upstream' is
the remote branch tracked by your current branch.  (The canonical
choice is upstream=origin/foo for a branch foo.)  git-fetch is of no
further interest to the discussion, as it does not touch the working
tree in any way.

git-rebase is not concerned with "newly fetched changes".  It
*rewinds* your branch to the updated 'upstream' tip, and then
*rebuilds* your commits on top of that.  This involves a lot of
resetting and applying patches, which appears to be why it enforces a
clean working tree.

You can use git-stash (see the man page) to temporarily save away your
uncommitted changes, however.  Maybe you could even write a patch to
git-rebase that lets it automatically save and restore uncommitted
changes?

> I almost always have modified files in my checkout for things I'm
> working on. I also often have a commit or two that haven't been pushed
> because I'm waiting until I get to a good point before pushing. If I
> do 'git pull', I end up with a merge commit each time. That's why I
> want to use --rebase, but for it to work, I have to git stash, then
> rebase then git stash pop.

You could probably improve your workflow a lot by using topic
branches.  See the recently added gitworkflows manpage, also available
at

  http://www.kernel.org/pub/software/scm/git-core/docs/gitworkflows.html

or, e.g., Tv's excellent introduction to git called "Version Control
for Du^H^HDevelopers":

  http://eagain.net/blog/2008/08/11/ep-talk-videos.html

(Pretty much the second half is about branch workflows, topic branches
are explicitly introduced at ~44:15.)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

      reply	other threads:[~2008-12-30 23:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30 21:40 Why can't git pull --rebase work if there are modified files? skillzero
2008-12-30 23:09 ` Thomas Rast [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812310009.12052.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=skillzero@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).