From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH] Add an import wizard for Eclipse projects as part of clone
Date: Wed, 31 Dec 2008 07:54:44 -0800 [thread overview]
Message-ID: <20081231155444.GH29071@spearce.org> (raw)
In-Reply-To: <1230720969-1735-1-git-send-email-robin.rosenberg@dewire.com>
Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> This adds an optional page for importing Eclipse style projects
> as part of the clone operation.
>
> This patch I think, greatly simplifies getting an Eclipse based project
> into the workbench.
Yes, yes it does!
> I'm mostly interested in comments on pure bugs. E.g. know it's
> blocking when the user selects to import the projects as part of the
> clone process, I also know I'm reusing internal messages and not supplying
> NLS style constansts for all textx.
I noticed you mispelled "showImportWizard" as "showImportWizarad",
but otherwise it looks reasonable to me. I'd like to see the NLS
stuff extracted out before we apply the patch though.
The blocking part is annoying, but there isn't really a better
way to do it. What would be worse is going into the background,
then popping open a modal dialog when it completes, as it would
really disrupts the user. So just don't clone massive projects
and expect to use your workbench at the same time. :-)
--
Shawn.
next prev parent reply other threads:[~2008-12-31 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 10:56 [EGIT PATCH] Add an import wizard for Eclipse projects as part of clone Robin Rosenberg
2008-12-31 15:54 ` Shawn O. Pearce [this message]
2009-01-02 6:18 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081231155444.GH29071@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).