From: Thomas Rast <trast@student.ethz.ch>
To: jidanni@jidanni.org
Cc: git@vger.kernel.org
Subject: Re: got wet with make --dry-run
Date: Thu, 1 Jan 2009 20:44:59 +0100 [thread overview]
Message-ID: <200901012045.02734.trast@student.ethz.ch> (raw)
In-Reply-To: <87eizn0xhd.fsf@jidanni.org>
[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]
jidanni@jidanni.org wrote:
> Gentlemen, make --dry-run is booby trapped to still execute commands:
> $ (cd Documentation; make --dry-run); find -mtime -1 -type f
> ./Documentation/doc.dep
> ./GIT-VERSION-FILE
> Forgot $(MAKEFLAGS)? (info "(make)Options/Recursion").
A two minute check into Makefile shows that the recursion is
implemented via $(MAKE), which is the recommended way to do it. It's
impossible to "forget" $(MAKEFLAGS), since the docs clearly say that
it is always exported unless explicitly unexported.
The *real* reason why it rebuilds GIT-VERSION-FILE is that the
Makefile says '-include GIT-VERSION-FILE', and uses the version info
to decide some parts of the build process. (It'll also do a similar
thing with the $CFLAGS detection code.) Since this influences the
actual commands executed, it seems sensible to run them even under
'make -n'.
> By the way, why would an offline make need
> /bin/sh: curl-config: command not found
From somewhere near the top of Makefile, which is definitely a
recommended read:
# Define NO_CURL if you do not have libcurl installed. git-http-pull and
# git-http-push are not built, and you cannot use http:// and https://
# transports.
Next time please take the time to investigate at least a little bit
into your "issues" before starting to cry foul.
--
Thomas Rast
trast@{inf,student}.ethz.ch
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2009-01-01 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 17:03 got wet with make --dry-run jidanni
2009-01-01 19:44 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901012045.02734.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
--cc=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).