Re: [CLEANUP PATCH RESEND] git wrapper: Make while loop more reader-friendly

["Boyd Stephen Smith Jr." <bss@iguanasuicide.net>]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Friday 2009 January 02 12:07:52 you wrote:
> It is not a good practice to prefer performance over readability in
> something as performance uncritical as finding the trailing slash
> of argv[0].
>
> So avoid head-scratching by making the loop user-readable, and not
> hyper-performance-optimized.

> -	do
> -		--slash;
> -	while (cmd <= slash && !is_dir_sep(*slash));
> +	while (cmd <= slash && !is_dir_sep(*slash))
> +		slash--;

What confused people?  The predecrement or the do/while?  Should people that 
don't understand one of those be hacking on git?

That said, I'm not opposed to the patch.  It is easier on the eyes, though I 
prefer the one-liner:
for (; cmd <= slash && !is_dir_sep(*slash); --slash);
-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss@iguanasuicide.net                     ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.net/                      \_/     

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]