* [PATCH] stgit namelength is an integer
@ 2009-01-05 19:03 Pete Wyckoff
2009-01-12 20:13 ` Karl Hasselström
0 siblings, 1 reply; 2+ messages in thread
From: Pete Wyckoff @ 2009-01-05 19:03 UTC (permalink / raw)
To: git
Interpret stgit namelength as an integer, else the use of
name_len will fail with
File "/usr/lib/python2.5/site-packages/stgit/utils.py", line 206, in patch_name_from_msg
return re.sub('[\W]+', '-', subject_line).strip('-')[:name_len]
TypeError: slice indices must be integers or None or have an __index__ method
Signed-off-by: Pete Wyckoff <pw@padd.com>
---
stgit/utils.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/stgit/utils.py b/stgit/utils.py
index 81035a5..1fa96c2 100644
--- a/stgit/utils.py
+++ b/stgit/utils.py
@@ -215,7 +215,7 @@ def patch_name_from_msg(msg):
if not msg:
return None
- name_len = config.get('stgit.namelength')
+ name_len = config.getint('stgit.namelength')
if not name_len:
name_len = 30
--
1.6.0.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] stgit namelength is an integer
2009-01-05 19:03 [PATCH] stgit namelength is an integer Pete Wyckoff
@ 2009-01-12 20:13 ` Karl Hasselström
0 siblings, 0 replies; 2+ messages in thread
From: Karl Hasselström @ 2009-01-12 20:13 UTC (permalink / raw)
To: Pete Wyckoff; +Cc: git
Thanks, but the test suite fails unless I apply this first:
Return None instead of crashing on undefined integer config items
Signed-off-by: Karl Hasselström <kha@treskal.com>
diff --git a/stgit/config.py b/stgit/config.py
index 8934445..5b47580 100644
--- a/stgit/config.py
+++ b/stgit/config.py
@@ -65,7 +65,9 @@ class GitConfig:
def getint(self, name):
value = self.get(name)
- if value.isdigit():
+ if value == None:
+ return None
+ elif value.isdigit():
return int(value)
else:
raise GitConfigException, 'Value for "%s" is not an integer: "%s"' % (name, value)
--
Karl Hasselström, kha@treskal.com
www.treskal.com/kalle
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-12 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-05 19:03 [PATCH] stgit namelength is an integer Pete Wyckoff
2009-01-12 20:13 ` Karl Hasselström
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).