From: Jeff King <peff@peff.net>
To: Joey Hess <joeyh@debian.org>
Cc: Gerrit Pape <pape@smarden.org>, git@vger.kernel.org
Subject: Re: gitweb: removal of old style blobdiff support breaks ikiwiki
Date: Mon, 5 Jan 2009 19:25:20 -0500 [thread overview]
Message-ID: <20090106002520.GA29000@coredump.intra.peff.net> (raw)
In-Reply-To: <20090105235418.GA9373@gnu.kitenet.net>
On Mon, Jan 05, 2009 at 06:54:18PM -0500, Joey Hess wrote:
> I wonder if it wouldn't be better to make gitweb continue to support the
> old urls, using diff-tree instead of the porcelain?
It can't; there is currently no interface for diffing two arbitrary
blobs except "git diff". The simplest fix to retain functionality but
plug the hole is to pass --no-ext-diff to all versions, and
--no-textconv to versions which have textconv (i.e., 1.6.1 and later).
IIRC, there is a problem with --no-ext-diff in some versions, so that
fix might have to be backported, too.
-Peff
prev parent reply other threads:[~2009-01-06 0:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 23:54 gitweb: removal of old style blobdiff support breaks ikiwiki Joey Hess
2009-01-06 0:25 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106002520.GA29000@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=joeyh@debian.org \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).