From: Pierre Habouzit <madcoder@debian.org>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] parse-opt: migrate builtin-ls-files.
Date: Tue, 06 Jan 2009 11:22:02 +0100 [thread overview]
Message-ID: <20090106102202.GA30766@artemis.corp> (raw)
In-Reply-To: <1231200669-30684-1-git-send-email-vmiklos@frugalware.org>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Tue, Jan 06, 2009 at 12:11:09AM +0000, Miklos Vajna wrote:
> +static int option_parse_no_empty(const struct option *opt,
> + const char *arg, int unset)
> +{
> + struct dir_struct *dir = opt->value;
> +
> + dir->hide_empty_directories = 1;
> +
> + return 0;
> +}
Should be option_parse_empty and deal with "unset" to know if `no-` was
prefixed to it or not.
> + { OPTION_CALLBACK, 0, "no-empty-directory", &dir, NULL,
> + "do not list empty directories",
This should be "empty-directory" and "list empty directories as well"
I've not checked if you could also check more of the "unsets" things in
your callbacks as well btw, but it looks like it could.
--
·O· Pierre Habouzit
··O madcoder@debian.org
OOO http://www.madism.org
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-06 10:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 0:11 [PATCH] parse-opt: migrate builtin-ls-files Miklos Vajna
2009-01-06 10:22 ` Pierre Habouzit [this message]
2009-01-07 3:11 ` [PATCH v2] " Miklos Vajna
2009-01-07 14:46 ` Pierre Habouzit
2009-01-08 0:55 ` [PATCH v3] " Miklos Vajna
2009-01-08 1:10 ` Johannes Schindelin
2009-01-08 1:54 ` Miklos Vajna
2009-01-15 0:14 ` Miklos Vajna
2009-01-15 3:16 ` Junio C Hamano
2009-01-15 3:48 ` Miklos Vajna
2009-02-14 12:16 ` Miklos Vajna
2009-02-14 20:04 ` Junio C Hamano
2009-02-14 20:56 ` Johannes Schindelin
2009-02-15 19:54 ` [PATCH] " Miklos Vajna
2009-02-15 20:13 ` Johannes Schindelin
2009-02-15 22:07 ` Miklos Vajna
2009-02-16 12:20 ` [PATCH] Turn the flags in struct dir_struct into a single variable Johannes Schindelin
2009-02-16 21:47 ` Miklos Vajna
2009-02-17 14:27 ` [PATCH] parse-opt: migrate builtin-ls-files Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090106102202.GA30766@artemis.corp \
--to=madcoder@debian.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).