From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: Funny: git -p submodule summary
Date: Fri, 9 Jan 2009 05:13:35 -0500 [thread overview]
Message-ID: <20090109101335.GA4346@coredump.intra.peff.net> (raw)
In-Reply-To: <49672244.80200@viscovery.net>
On Fri, Jan 09, 2009 at 11:09:08AM +0100, Johannes Sixt wrote:
> > Below is a patch that uses the three-process mechanism, and it fixes the
> > problem. _But_ it is not satisfactory for inclusion, because it won't
> > work on MINGW32. Since it is actually splitting git into two processes
> > (one to monitor the pager and one to actually run git), it uses fork.
>
> We have start_async()/finish_async() to replace a fork() of the sort that
> we have here.
It looks like start_async is implemented using threads on Windows. Will
that survive an execvp call? Because we don't know at this point whether
we are going to actually run builtin code, or if we will exec an
external.
-Peff
next prev parent reply other threads:[~2009-01-09 10:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 15:07 Funny: git -p submodule summary Johannes Schindelin
2009-01-08 15:30 ` Johannes Schindelin
2009-01-09 8:38 ` Jeff King
2009-01-09 9:22 ` Jeff King
2009-01-09 9:48 ` Jeff King
2009-01-09 10:09 ` Johannes Sixt
2009-01-09 10:13 ` Jeff King [this message]
2009-01-09 10:36 ` Johannes Sixt
2009-01-09 10:47 ` Jeff King
2009-01-11 11:22 ` Jeff King
2009-01-11 11:25 ` [PATCH 1/4] Makefile: clean up TEST_PROGRAMS definition Jeff King
2009-01-11 11:32 ` [PATCH 2/4] chain kill signals for cleanup functions Jeff King
2009-01-11 11:40 ` Jeff King
2009-01-11 11:36 ` [PATCH 3/4] refactor signal handling " Jeff King
2009-01-11 11:36 ` [PATCH 4/4] pager: do wait_for_pager on signal death Jeff King
2009-01-11 21:13 ` Junio C Hamano
2009-01-12 10:59 ` Funny: git -p submodule summary Johannes Sixt
2009-01-12 11:21 ` Jeff King
2009-01-12 12:00 ` Johannes Sixt
2009-01-12 12:03 ` Jeff King
2009-01-12 12:19 ` Johannes Sixt
2009-01-09 9:30 ` Junio C Hamano
2009-01-09 9:33 ` Jeff King
2009-01-09 9:38 ` Junio C Hamano
2009-01-27 6:25 ` [RFC/PATCH 0/3] fix "Funny: git -p submodule summary" Jeff King
2009-01-27 6:26 ` [RFC/PATCH 1/3] git: s/run_command/run_builtin/ Jeff King
2009-01-27 6:27 ` [RFC/PATCH 2/3] run_command: handle missing command errors more gracefully Jeff King
2009-01-27 6:27 ` [RFC/PATCH 3/3] git: use run_command to execute dashed externals Jeff King
2009-01-27 10:06 ` [RFC/PATCH 0/3] fix "Funny: git -p submodule summary" Johannes Sixt
2009-01-27 12:23 ` Jeff King
2009-01-27 12:46 ` Johannes Sixt
2009-01-28 7:17 ` Jeff King
2009-01-27 16:31 ` Johannes Schindelin
2009-01-28 7:30 ` Jeff King
2009-01-28 7:33 ` [PATCHv2 1/4] git: s/run_command/run_builtin/ Jeff King
2009-01-28 7:35 ` [PATCHv2 2/4] run_command: handle missing command errors more gracefully Jeff King
2009-01-28 7:36 ` [PATCHv2 3/4] run-command: help callers distinguish errors Jeff King
2009-01-28 7:43 ` Jeff King
2009-01-28 7:47 ` Jeff King
2009-01-28 7:38 ` [PATCHv2 4/4] git: use run_command to execute dashed externals Jeff King
2009-01-28 7:54 ` [RFC/PATCH 0/3] fix "Funny: git -p submodule summary" Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109101335.GA4346@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).