From: Alexander Potashev <aspotashev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Nathan W. Panike" <nathan.panike@gmail.com>, git@vger.kernel.org
Subject: [PATCH] format-patch: avoid generation of empty patches
Date: Sat, 10 Jan 2009 14:39:03 +0300 [thread overview]
Message-ID: <20090110113903.GB25723@myhost> (raw)
In-Reply-To: <20090110113642.GA25723@myhost>
If 'log.showroot' is not set, format-patch shouldn't even try to create
a patch for the root commit.
Signed-off-by: Alexander Potashev <aspotashev@gmail.com>
---
builtin-log.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/builtin-log.c b/builtin-log.c
index 4a02ee9..62134d4 100644
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -972,6 +972,9 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
has_commit_patch_id(commit, &ids))
continue;
+ if (!commit->parents && !rev.show_root_diff)
+ break;
+
nr++;
list = xrealloc(list, nr * sizeof(list[0]));
list[nr - 1] = commit;
--
1.6.1.77.g569c.dirty
next prev parent reply other threads:[~2009-01-10 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 21:33 [PATCH] Get format-patch to show first commit after root commit Nathan W. Panike
2009-01-10 0:49 ` Junio C Hamano
2009-01-10 1:37 ` Nathan W. Panike
2009-01-10 11:36 ` Alexander Potashev
2009-01-10 11:39 ` Alexander Potashev [this message]
2009-01-10 16:01 ` [PATCH] format-patch: avoid generation of empty patches Nathan W. Panike
2009-01-10 16:17 ` Alexander Potashev
2009-01-10 18:07 ` Nathan W. Panike
2009-01-10 20:41 ` Junio C Hamano
2009-01-10 16:39 ` [PATCH] Add new testcases for format-patch root commits Alexander Potashev
2009-01-10 18:33 ` Alexander Potashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090110113903.GB25723@myhost \
--to=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nathan.panike@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).