git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH 7/7] Create an automatic UI test for the Git Import Wizard
Date: Mon, 12 Jan 2009 08:45:14 -0800	[thread overview]
Message-ID: <20090112164514.GG10179@spearce.org> (raw)
In-Reply-To: <200901081957.20591.robin.rosenberg.lists@dewire.com>

Robin Rosenberg <robin.rosenberg.lists@dewire.com> wrote:
> 
> We could hold onto this patch. It might be better if we start the built in git daemon and clone
> from it, or from file, instread of jgit.org, but please try it out and see if it looks like a good a approach to
> use SWTBot for UI tests.

I'm not applying this patch for two reasons:

1) I spent 30 minutes trying to get SWTBot installed and running,
I gave up.  It doesn't want to run in my Eclipse.  Heck, I didn't
even get as far as running, I couldn't get it to install far enough
to get the project to compile.

2) I really want to avoid remote network access during JUnit tests.
Now that we have our own server process we can run it over a pipe
or something to do this test.  Or at worst, bind to a random port
on the loopback and have the client clone from that port.

-- 
Shawn.

      reply	other threads:[~2009-01-12 16:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-08 16:56 [EGIT PATCH 0/7] Import Wizard cleanup fixes and test Robin Rosenberg
2009-01-08 16:56 ` [EGIT PATCH 1/7] Create the import wizard question checkbox properly Robin Rosenberg
2009-01-08 16:56   ` [EGIT PATCH 2/7] Fix two strings in the cloning wizard that were not translated Robin Rosenberg
2009-01-08 16:56     ` [EGIT PATCH 3/7] Add shortcuts to the Git cloning wizard Robin Rosenberg
2009-01-08 16:56       ` [EGIT PATCH 4/7] Normalize paths to /-format when parsing GIT URI's Robin Rosenberg
2009-01-08 16:56         ` [EGIT PATCH 5/7] Add UNC test case to URIish test Robin Rosenberg
2009-01-08 16:56           ` [EGIT PATCH 6/7] Treat null scheme as file: in git import wizard Robin Rosenberg
2009-01-08 16:56             ` [EGIT PATCH 7/7] Create an automatic UI test for the Git Import Wizard Robin Rosenberg
2009-01-08 18:45               ` Robin Rosenberg
2009-01-08 18:57               ` Robin Rosenberg
2009-01-12 16:45                 ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112164514.GG10179@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg.lists@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).