From: "Shawn O. Pearce" <spearce@spearce.org>
To: "Boyd Stephen Smith Jr." <bss@iguanasuicide.net>
Cc: "Adeodato Simó" <dato@net.com.org.es>,
"Ted Pavlic" <ted@tedpavlic.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Update bash completions to prevent unbound variable errors.
Date: Mon, 12 Jan 2009 13:31:49 -0800 [thread overview]
Message-ID: <20090112213149.GL10179@spearce.org> (raw)
In-Reply-To: <200901121527.21818.bss@iguanasuicide.net>
"Boyd Stephen Smith Jr." <bss@iguanasuicide.net> wrote:
>
> Well, if the user want to run in "set -u" mode preventing it is bogus, IMO.
> We could use subshells and unset at the top of _git and _gitk functions, that
> would be only a +6/-4 patch. It would also not be something future
> contributors have to think (much) about.
Running in subshells is a bad idea. We'd likely lose access
to the completion word array, and it would take a lot longer per
completion because you need to spin-up and tear-down that subshell.
We have spent some time to make the current completion code use as
few forks as possible to get the results we want, because it runs
faster that way.
--
Shawn.
next prev parent reply other threads:[~2009-01-12 21:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 19:58 [PATCH] Update bash completions to prevent unbound variable errors Ted Pavlic
2009-01-12 20:35 ` Boyd Stephen Smith Jr.
2009-01-12 20:40 ` Adeodato Simó
2009-01-12 21:27 ` Boyd Stephen Smith Jr.
2009-01-12 21:31 ` Shawn O. Pearce [this message]
2009-01-12 21:38 ` Boyd Stephen Smith Jr.
2009-01-12 21:11 ` Ted Pavlic
2009-01-12 21:21 ` Ted Pavlic
2009-01-12 21:32 ` Shawn O. Pearce
2009-01-12 21:51 ` Ted Pavlic
2009-01-12 21:25 ` Adeodato Simó
2009-01-12 21:37 ` Ted Pavlic
2009-01-12 21:47 ` Adeodato Simó
2009-01-12 21:40 ` Adeodato Simó
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112213149.GL10179@spearce.org \
--to=spearce@spearce.org \
--cc=bss@iguanasuicide.net \
--cc=dato@net.com.org.es \
--cc=git@vger.kernel.org \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).