From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Ryan Alberts <ralberts@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH EGIT Allow for git config to not error when lines have '/r' in them.]
Date: Mon, 12 Jan 2009 23:53:19 +0100 [thread overview]
Message-ID: <200901122353.19408.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <20090112171045.GI10179@spearce.org>
"Shawn O. Pearce" <spearce@spearce.org> wrote
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > torsdag 08 januari 2009 04:10:05 skrev Ryan Alberts:
> > > I have attached a small fix for when a git config has /r lines in the file.
> > > I have to admit that I do not usually submit patches to the open source
> > > community and I am not very familiar with the process :-) Please, please,
> > > let me know if I can do something different next time!
> >
> > Back to the patch. I think we should only ignore \r (not /r, but could say CR in
> > a comment) before an LF.
>
> I disagree; ignoring CR anyplace in the file should be fine, unless
> it is within a double quoted value, in which case it should use
> the same rule that \n would use within the same region.
>
> ' ', \n, \t all act the same with regards to being (mostly) ignored
> whitespace. \r is no different. Especially for anyone crazy enough
> to still be using a Mac style formatted file, with only CRs in it.
Those are copied from in to out in the repo config parser today. Why
should ' \r' be treated differently? Just CR (FF, Ctrl-G etc) is garbage,
but CRLF is a well established line terminator.
-- robin
prev parent reply other threads:[~2009-01-12 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <142772020901071910ha95d53fo2454f8685908338c@mail.gmail.com>
2009-01-10 20:34 ` [PATCH EGIT Allow for git config to not error when lines have '/r' in them.] Robin Rosenberg
2009-01-12 17:10 ` Shawn O. Pearce
2009-01-12 22:53 ` Robin Rosenberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901122353.19408.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=ralberts@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).