From: "Adeodato Simó" <dato@net.com.org.es>
To: "Boyd Stephen Smith Jr." <bss@iguanasuicide.net>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
Ted Pavlic <ted@tedpavlic.com>, git <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u."
Date: Tue, 13 Jan 2009 21:10:24 +0100 [thread overview]
Message-ID: <20090113201024.GA20129@chistera.yi.org> (raw)
In-Reply-To: <200901131403.16012.bss@iguanasuicide.net>
* Boyd Stephen Smith Jr. [Tue, 13 Jan 2009 14:03:11 -0600]:
> On Tuesday 2009 January 13 10:45:18 Shawn O. Pearce wrote:
> >See [...] how the subject is a niceshort, one
> >line summary of the module impacted and the change?
> My rule for this is absolutely no more than 80 characters.
My rule for *all* of the commit message is "absolutely no more than 76
characters". With more than 76, `git log` wraps in a 80-column terminal.
Just my 2¢,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
La música es de los que la quieren escuchar y de nadie más.
-- Andrés Calamaro
next prev parent reply other threads:[~2009-01-13 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 16:11 [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u." Ted Pavlic
2009-01-13 16:45 ` Shawn O. Pearce
2009-01-13 20:03 ` Boyd Stephen Smith Jr.
2009-01-13 20:10 ` Adeodato Simó [this message]
2009-01-13 20:24 ` Commit messages Teemu Likonen
2009-01-14 16:55 ` Ted Pavlic
2009-01-15 22:56 ` [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u." Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090113201024.GA20129@chistera.yi.org \
--to=dato@net.com.org.es \
--cc=bss@iguanasuicide.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).