git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: skillzero@gmail.com
Cc: git@vger.kernel.org
Subject: Re: git merge and cherry-pick and duplicated commits?
Date: Wed, 14 Jan 2009 09:41:14 +0100	[thread overview]
Message-ID: <200901140941.17110.trast@student.ethz.ch> (raw)
In-Reply-To: <2729632a0901132221r746144a1y9628615be1c6ad04@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

skillzero@gmail.com wrote:
> I thought git would realize that master already had those 2 commits
> and not add them again when merging?

[later]
> That's what I was somewhat disappointed by. Even though the result of
> the commit had a different hash, I assumed git would keep some kind of
> internal per-commit hash so it could tell later that two commits were
> the same and not re-apply them.

I think there's an important misunderstanding here: merging A into B
does *not* have anything to do with commits, or history for that
matter, beyond the differences from $(git merge-base A B) to A and
B.[*]

Along the same lines, nothing is ever re-applied during merging.
git-merge just figures out that you made the same change on both
sides, so it must have been a good change, so it must go into the end
result.  *How* you arrived at the same change---say, by
cherry-picking, or by getting the same result in that region from
otherwise different commits, or even from several commits---does *not*
matter in any way.

You can use 'git cherry', 'git log --left-right --cherry-pick', and
similar tools to find commits that are cherry-picked "duplicates", but
unless you rewrite history, they are there to stay.


[*] This is a simplification since as soon as the merge-base is not
unique, merge-recursive will actually start looking into history
further back.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch



[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2009-01-14  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14  2:40 git merge and cherry-pick and duplicated commits? skillzero
2009-01-14  5:31 ` Brian Gernhardt
2009-01-14  6:21   ` skillzero
2009-01-14  7:34     ` Johannes Sixt
2009-01-14  8:08       ` skillzero
2009-01-14  8:34         ` Johannes Sixt
2009-01-14 18:33           ` skillzero
2009-01-14 19:40             ` Peter Baumann
2009-01-14 20:16             ` Junio C Hamano
2009-01-15 23:09             ` Markus Heidelberg
2009-01-14  8:38         ` Boaz Harrosh
2009-01-14  8:41     ` Thomas Rast [this message]
2009-01-14 13:47       ` Alex Riesen
2009-01-14  7:33   ` skillzero
2009-01-14 15:53     ` Sitaram Chamarty
2009-01-14  8:31   ` Nanako Shiraishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901140941.17110.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=skillzero@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).