From: "Adeodato Simó" <dato@net.com.org.es>
To: Jeff King <peff@peff.net>
Cc: Jan Engelhardt <jengelh@medozas.de>, git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname
Date: Wed, 14 Jan 2009 15:17:23 +0100 [thread overview]
Message-ID: <20090114141723.GA6984@chistera.yi.org> (raw)
In-Reply-To: <20090114122536.GA5939@coredump.intra.peff.net>
* Jeff King [Wed, 14 Jan 2009 07:25:36 -0500]:
> On Wed, Jan 14, 2009 at 11:48:38AM +0100, Jan Engelhardt wrote:
> > This is much shorter than inet_ntop'ing, and also translated
> > unresolvable addresses into a string.
> Er, doesn't this totally change the meaning of REMOTE_ADDR from an IP
> address to a hostname?
Yes, I believe so.
However, AFAIK you can obtain the intended behavior if you pass
NI_NUMERICHOST as a flag to the getnameinfo() call. With that, this
patch can be still considered for inclusing if the original "don't
hardcode protocol-specific bits" is still deemed worthy.
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
- Why are you whispering?
- Because I just think that no matter where she is, my mom can hear this
conversation.
-- Rory and Lane
next prev parent reply other threads:[~2009-01-14 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 10:48 [PATCH 1/3] git-daemon: single-line logs Jan Engelhardt
2009-01-14 10:48 ` [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Jan Engelhardt
2009-01-14 10:49 ` [PATCH 3/3] git-daemon: vhost support Jan Engelhardt
2009-01-14 11:33 ` Junio C Hamano
2009-01-14 13:15 ` Jan Engelhardt
2009-01-14 11:33 ` [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Junio C Hamano
2009-01-14 13:06 ` Jan Engelhardt
2009-01-14 12:25 ` Jeff King
2009-01-14 14:17 ` Adeodato Simó [this message]
2009-01-14 14:22 ` Jay Soffian
2009-01-14 19:25 ` [2/3] " Jan Engelhardt
2009-01-14 11:33 ` [PATCH 1/3] git-daemon: single-line logs Junio C Hamano
2009-01-14 13:03 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090114141723.GA6984@chistera.yi.org \
--to=dato@net.com.org.es \
--cc=git@vger.kernel.org \
--cc=jengelh@medozas.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).