git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Beyer <s-beyer@gmx.net>
To: Sitaram Chamarty <sitaramc@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: rebase -p confusion in 1.6.1
Date: Thu, 15 Jan 2009 14:38:08 +0100	[thread overview]
Message-ID: <20090115133808.GA10045@leksak.fem-net> (raw)
In-Reply-To: <slrngmu4j5.e1u.sitaramc@sitaramc.homelinux.net>

Hi Sitaram,

Sitaram Chamarty wrote:
> The outputs I got really confused me.  Before the "rebase
> -p", the tree looked like
>     
>     * 78ffda9... (refs/heads/work) b4
>     * be1e3a4... b3
>     *   cd8d893... Merge branch 'master' into work
>     |\
>     | * 0153c27... (refs/heads/master) a4
>     | * 74f4387... a3
>     * | f1b0c1c... b2
>     * | 2e202d0... b1
>     |/
>     * b37ae36... a2
>     * ed1e1bc... a1
> 
> But afterward, this is what it looks like -- all the "b"
> commits are gone!
> 
>     * 0153c27... (refs/heads/work, refs/heads/master) a4
>     * 74f4387... a3
>     * b37ae36... a2
>     * ed1e1bc... a1
> 
> What did I do wrong/misunderstand?

Hmm, you are rebasing onto master which is merged into the branch you
want to rebase. So, I think the correct output should be the same like
git rebase without -p, ie

* 1337bee... (refs/heads/work) b4
* deadbee... b3
* badbeef... b2
* fa1afe1... b1
* 0153c27... (refs/heads/master) a4
* 74f4387... a3
* b37ae36... a2
* ed1e1bc... a1

This is because master is already merged into work and a preserved
merge will see that everything is already merged in.

Well, so I think you've discovered a bug.

> (2) git config alias.lg log --graph --pretty=oneline --abbrev-commit --decorate

Funny, I have exactly the same alias, but named "logk".

>     git init
>     testci a1 a2
>     git checkout -b work
>     testci b1 b2
>     git checkout master
>     testci a3 a4
>     git checkout work
>     git merge master
>     testci b3 b4
>     git --no-pager lg   # graph before rebase -p
>     git rebase -p master
>     git --no-pager lg   # graph after rebase -p

Thanks and regards,
  Stephan

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F

  parent reply	other threads:[~2009-01-15 13:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 10:39 rebase -p confusion in 1.6.1 Sitaram Chamarty
2009-01-15 13:34 ` Johannes Schindelin
2009-01-15 14:51   ` Sitaram Chamarty
2009-01-15 15:09     ` Stephan Beyer
2009-01-15 15:21       ` Sitaram Chamarty
2009-01-15 13:38 ` Stephan Beyer [this message]
2009-01-15 13:58   ` Johannes Schindelin
2009-01-15 15:03     ` Sitaram Chamarty
2009-01-15 13:39 ` Michael J Gruber
2009-01-15 13:55   ` Stephan Beyer
2009-01-15 14:14     ` Michael J Gruber
2009-01-15 14:25       ` Johannes Schindelin
2009-01-15 14:45         ` Michael J Gruber
2009-01-15 16:04           ` Johannes Schindelin
2009-01-15 16:24             ` Sitaram Chamarty
2009-01-15 16:53               ` Johannes Schindelin
2009-01-15 18:22                 ` Sitaram Chamarty
2009-01-15 16:56             ` Michael J Gruber
2009-01-15 18:18               ` Johannes Schindelin
     [not found]               ` <cover.1232233454.git.stephen@exigencecorp.com>
2009-01-17 23:41                 ` [PATCH] do not drop commits before the merge base Johannes Schindelin
     [not found]                 ` <ac1a4533de095f916dd68029793c8ee6eb02d200.1232233454.git.stephen@exigencecorp.com>
     [not found]                   ` <a524993b13ee586cf0e8fbd3b6459ccd6767c6d8.1232233454.git.stephen@exigencecorp.com>
2009-01-17 23:51                     ` [PATCH] rebase -p: seed first commit in case it's before the merge bases Johannes Schindelin
2009-01-18  0:11                       ` Stephen Haberman
2009-01-18  0:19                       ` Johannes Schindelin
2009-01-18  3:57                         ` Stephen Haberman
2009-01-18  4:02                           ` Stephen Haberman
2009-01-15 14:40       ` rebase -p confusion in 1.6.1 Stephan Beyer
2009-01-15 16:43         ` Johannes Schindelin
2009-01-15 15:14   ` Sitaram Chamarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090115133808.GA10045@leksak.fem-net \
    --to=s-beyer@gmx.net \
    --cc=git@vger.kernel.org \
    --cc=sitaramc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).