git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Steinbrink" <B.Steinbrink@gmx.de>
To: Pieter de Bie <pieter@frim.nl>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Sverre Rabbelier <srabbelier@gmail.com>,
	Johan Herland <johan@herland.net>,
	git@vger.kernel.org, Johannes Sixt <j.sixt@viscovery.net>,
	Anders Melchiorsen <mail@cup.kalibalik.dk>,
	gitster@pobox.com
Subject: Re: [RFC PATCH] Make the rebase edit mode really end up in an edit state
Date: Thu, 15 Jan 2009 14:46:12 +0100	[thread overview]
Message-ID: <20090115134612.GA6556@atjola.homenet> (raw)
In-Reply-To: <8B5B7148-B900-4E01-9B2C-16C251966F7F@frim.nl>

On 2009.01.15 12:57:04 +0000, Pieter de Bie wrote:
>
> On Jan 15, 2009, at 12:36 PM, Johannes Schindelin wrote:
>
>> BTW I was not fully happy with 'edit' back then, either, which is the
>> reason why I showed the usage in the comment _above_ the commit list.  
>> But
>> nobody could suggest a name that I found convincingly better.
>
> (BTW, I reply to this thread because I'm also often confused with the
> rebase. The thing that hits me most is that with resolving conflicts,
> you have to do a 'git commit' and with 'edit', you have to do a 'git
> commit --amend'. This can get confusing if you set up an interactive
> rebase where you have some new picks or squashes, and also an edit.
> If the rebase stops, you first have to carefully read whether you're
> supposed to do a 'git commit' or a 'git commit --amend', and remember
> that until you're finished with the changes).

You can handle both cases with:
git add -u # Or whatever
git rebase --continue

Only when you split a commit, you have to explicitly reset and commit.

Björn

  reply	other threads:[~2009-01-15 13:47 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15  0:27 [RFC PATCH] Make the rebase edit mode really end up in an edit state Anders Melchiorsen
2009-01-15  0:43 ` Junio C Hamano
2009-01-15  2:49   ` Boyd Stephen Smith Jr.
2009-01-15  4:10     ` Miles Bader
2009-01-15  5:00       ` Boyd Stephen Smith Jr.
2009-01-15  6:13       ` Junio C Hamano
2009-01-15 12:24       ` Johannes Schindelin
2009-01-15 15:35   ` SZEDER Gábor
2009-01-15 22:09     ` Junio C Hamano
2009-01-15 22:20       ` Sverre Rabbelier
2009-01-15 22:59         ` SZEDER Gábor
2009-01-16  0:11           ` Björn Steinbrink
2009-01-16  1:34             ` Johannes Schindelin
2009-01-18  1:24             ` Anders Melchiorsen
2009-01-16  1:09           ` Junio C Hamano
2009-01-16 12:10             ` Johannes Schindelin
2009-01-15  0:49 ` Stephan Beyer
2009-01-15  0:53 ` Johannes Schindelin
2009-01-15  7:35   ` Johannes Sixt
2009-01-15 10:01     ` Johan Herland
2009-01-15 11:52       ` Sverre Rabbelier
2009-01-15 12:36         ` Johannes Schindelin
2009-01-15 12:44           ` Adeodato Simó
2009-01-15 13:41             ` Johannes Schindelin
2009-01-15 13:41               ` Sverre Rabbelier
2009-01-15 13:57                 ` Stephan Beyer
2009-01-15 14:02                   ` Johannes Schindelin
2009-01-15 13:43               ` Adeodato Simó
2009-01-15 12:45           ` Sverre Rabbelier
2009-01-15 13:42             ` Johannes Schindelin
2009-01-15 13:56               ` Sverre Rabbelier
2009-01-15 16:59             ` Junio C Hamano
2009-01-15 17:16               ` Sverre Rabbelier
2009-01-15 18:21               ` Johannes Schindelin
2009-01-15 18:46                 ` Johan Herland
2009-01-15 18:53                   ` Anders Melchiorsen
2009-01-15 19:28                     ` Johannes Schindelin
2009-01-15 19:27                   ` Wincent Colaiuta
2009-01-15 20:26                     ` Jay Soffian
2009-01-15 21:58                       ` Wincent Colaiuta
2009-01-16  9:50                       ` Johan Herland
2009-01-16 10:27                         ` Anders Melchiorsen
2009-01-16 10:58                           ` Johan Herland
2009-01-16 12:42                             ` SZEDER Gábor
2009-01-16 12:57                               ` Johannes Schindelin
2009-01-16 13:27                                 ` SZEDER Gábor
2009-01-16 14:28                                   ` Wincent Colaiuta
2009-01-16 13:12                         ` Sverre Rabbelier
2009-01-16 17:26                           ` Stephan Beyer
2009-01-16 21:06                             ` Johannes Schindelin
2009-01-15 12:52           ` Pieter de Bie
2009-01-15 12:55             ` Sverre Rabbelier
2009-01-15 12:57           ` Pieter de Bie
2009-01-15 13:46             ` Björn Steinbrink [this message]
2009-01-15 13:54         ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090115134612.GA6556@atjola.homenet \
    --to=b.steinbrink@gmx.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=johan@herland.net \
    --cc=mail@cup.kalibalik.dk \
    --cc=pieter@frim.nl \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).