From: "George Spelvin" <linux@horizon.com>
To: Johannes.Schindelin@gmx.de, gitster@pobox.com
Cc: linux@horizon.com, git@vger.kernel.org
Subject: Re: fatal: git grep: cannot generate relative filenames containing '..'
Date: Thu, 15 Jan 2009 22:27:08 -0500 [thread overview]
Message-ID: <20090116032708.21156.qmail@science.horizon.com> (raw)
In-Reply-To: <7vhc40ov78.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> wrote:
> Or perhaps someone did more than two years ago with --full-name?
Thank you for pointing that out! It's a bit of a handful to type,
but at least it makes what I want to do possible without having to
write a wrapper script. And I can reduce the typing with an alias.
I'm still trying to figure out why the basic form doesn't work,
though. Is there something more subtle than that fact that the
filename simplification in grep_sha1 and grep_file might do the
wrong thing? If I comment out the check in cmd_grep(), it seems
to work, although it prints out some funky filenames.
That seems like a straightforward thing to fix. Basically, strip
off the common part of the prefix and name, and for every remaining
component in the prefix, prepend a ../ to the name.
I don't mind doing the coding, but can someone who groks the
code more fully tell me if I'm missing something major?
next prev parent reply other threads:[~2009-01-16 3:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 22:29 fatal: git grep: cannot generate relative filenames containing '..' George Spelvin
2009-01-15 23:04 ` Markus Heidelberg
2009-01-16 1:52 ` Junio C Hamano
2009-01-16 21:30 ` Jon Loeliger
2009-01-17 2:21 ` Hannu Koivisto
2009-01-18 16:58 ` George Spelvin
2009-01-16 2:07 ` Johannes Schindelin
2009-01-16 2:12 ` Junio C Hamano
2009-01-16 3:27 ` George Spelvin [this message]
2009-01-16 4:24 ` George Spelvin
2009-01-16 11:41 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116032708.21156.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).