'mail' link on http://repo.or.cz/w/git.git no workee?

'mail' link on http://repo.or.cz/w/git.git no workee?

[Johannes Schindelin]

Hi Pasky,

sorry to bother you between two games of Go; Could you have a look at the 
'mail' link with the commit "Update 1.6.2 draft release notes"?  It is not 
working for me...

That is, it links to marc (not gmane?) but finds no matches...

Ciao,
Dscho

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Petr Baudis]

  Hi,

On Thu, Jan 15, 2009 at 04:53:48PM +0100, Johannes Schindelin wrote:
> sorry to bother you between two games of Go; Could you have a look at the 
> 'mail' link with the commit "Update 1.6.2 draft release notes"?  It is not 
> working for me...
> 
> That is, it links to marc (not gmane?) but finds no matches...

  what mailing list post should it point to?

				Petr "Pasky" Baudis

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Junio C Hamano]

Petr Baudis <pasky@suse.cz> writes:

>> That is, it links to marc (not gmane?) but finds no matches...
>
>   what mailing list post should it point to?

I think Dscho's point is that you shouldn't be generating these links that
lead to nowhere ;-).

It would really be nice if we can maintain an exterenal database that
links mailing list discussion threads and individual commits, and have
gitweb and other visualization tools to make use of that information.

I do not care what storage mechanism that external database uses.  It
could use notes or it could just be a BDB that can be indexed with commit
object names.

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Johannes Schindelin]

Hi,

On Thu, 15 Jan 2009, Junio C Hamano wrote:

> Petr Baudis <pasky@suse.cz> writes:
> 
> >> That is, it links to marc (not gmane?) but finds no matches...
> >
> >   what mailing list post should it point to?

I found gmane to be much nicer to click through than marc.

> I think Dscho's point is that you shouldn't be generating these links 
> that lead to nowhere ;-).

Almost.

I wondered what the point was, and I would _welcome_ links that pointed to 
the mails containing the patches (identified either by patch ids or by 
manual editing; best would be to have both methods at the same time).

Ciao,
Dscho

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Petr Baudis]

On Fri, Jan 16, 2009 at 03:17:14AM +0100, Johannes Schindelin wrote:
> On Thu, 15 Jan 2009, Junio C Hamano wrote:
> 
> > Petr Baudis <pasky@suse.cz> writes:
> > 
> > >> That is, it links to marc (not gmane?) but finds no matches...
> > >
> > >   what mailing list post should it point to?
> 
> I found gmane to be much nicer to click through than marc.

IIRC I found no way to actually make a gmane link since it requires POST
query for the searches or something.

> > I think Dscho's point is that you shouldn't be generating these links 
> > that lead to nowhere ;-).
> 
> Almost.
> 
> I wondered what the point was, and I would _welcome_ links that pointed to 
> the mails containing the patches (identified either by patch ids or by 
> manual editing; best would be to have both methods at the same time).

Well, but you already have that, or at least an approximation. Do you
think the approximation is inadequate? I would expect linking to a
commit showing the inadequacy - I don't see how a false positive is
inadequate at all, actually; even if we had a separate database with the
mapping, for no records I think falling back to linking to a mailing
list search still makes more sense than showing no link.

I was not actually planning to carry the patch over the next gitweb
update since I got no feedback on it (IIRC) since I implemented it.

-- 
				Petr "Pasky" Baudis
The average, healthy, well-adjusted adult gets up at seven-thirty
in the morning feeling just terrible. -- Jean Kerr

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Jacob Helwig]

On Thu, Jan 15, 2009 at 18:24, Petr Baudis <pasky@suse.cz> wrote:
>
> IIRC I found no way to actually make a gmane link since it requires POST
> query for the searches or something.
>

$ cat bin/gmane-links.pl
#!/usr/bin/perl

use strict;
use warnings;

use Mail::Summary::Tools::ArchiveLink::Gmane;

unless ($ARGV[0]) {
    print STDERR "Must provide a message-id.\n";
    exit 1;
}

my $link = Mail::Summary::Tools::ArchiveLink::Gmane->new(message_id =>
$ARGV[0]);

print "Thread: " . $link->thread_uri() . "\n";
print "Message: " . $link->message_uri() . "\n";

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Junio C Hamano]

"Jacob Helwig" <jacob.helwig@gmail.com> writes:

> On Thu, Jan 15, 2009 at 18:24, Petr Baudis <pasky@suse.cz> wrote:
>>
>> IIRC I found no way to actually make a gmane link since it requires POST
>> query for the searches or something.
>>
>
> $ cat bin/gmane-links.pl
> #!/usr/bin/perl
>
> use strict;
> use warnings;
>
> use Mail::Summary::Tools::ArchiveLink::Gmane;
>
> unless ($ARGV[0]) {
>     print STDERR "Must provide a message-id.\n";
>     exit 1;
> }
>
> my $link = Mail::Summary::Tools::ArchiveLink::Gmane->new(message_id =>
> $ARGV[0]);
>
> print "Thread: " . $link->thread_uri() . "\n";
> print "Message: " . $link->message_uri() . "\n";

Not quite, if message_id means what I think it means.

Pasky searches for the title of the message, and he does not have the
Message-ID header of the original message.

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Junio C Hamano]

Petr Baudis <pasky@suse.cz> writes:

> I was not actually planning to carry the patch over the next gitweb
> update since I got no feedback on it (IIRC) since I implemented it.

Heh, now you got it.

And I do not think you advertised it since you implemented it, so no
feedback does not necessarily mean no interest.  FWIW, I think looking for
a message that has similar words in the mail archive is a nifty feature to
have.

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Jens Seidel]

On Fri, Jan 16, 2009 at 02:54:39AM +0100, Petr Baudis wrote:
> On Thu, Jan 15, 2009 at 04:53:48PM +0100, Johannes Schindelin wrote:
> > sorry to bother you between two games of Go; Could you have a look at the 
> > 'mail' link with the commit "Update 1.6.2 draft release notes"?  It is not 
> > working for me...
> > 
> > That is, it links to marc (not gmane?) but finds no matches...

Just a side note: The link to the mailing list on http://git-scm.com/ is also
not optimal as it refers to gmane. I tried to subscribe but found only a link
to http://dir.gmane.org/gmane.comp.version-control.git and no instructions how
to subscribe ...

Jens

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Johannes Schindelin]

Hi,

On Fri, 16 Jan 2009, Petr Baudis wrote:

> On Fri, Jan 16, 2009 at 03:17:14AM +0100, Johannes Schindelin wrote:
> 
> > I wondered what the point was, and I would _welcome_ links that 
> > pointed to the mails containing the patches (identified either by 
> > patch ids or by manual editing; best would be to have both methods at 
> > the same time).
> 
> Well, but you already have that, or at least an approximation.

Oh, I see!  Somehow I missed that this link exists for all non-merge 
commits...

> I was not actually planning to carry the patch over the next gitweb 
> update since I got no feedback on it (IIRC) since I implemented it.

Well, now you got one: I find it nice.  And I agree with you on the false 
positive thing: it is better to have that link also for commits for which 
no mails can be found.

I just had to scratch my head about what "mail" is about...

Ciao,
Dscho

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Johannes Schindelin]

Hi,

On Fri, 16 Jan 2009, Petr Baudis wrote:

> On Fri, Jan 16, 2009 at 03:17:14AM +0100, Johannes Schindelin wrote:
> > On Thu, 15 Jan 2009, Junio C Hamano wrote:
> > 
> > > Petr Baudis <pasky@suse.cz> writes:
> > > 
> > > >> That is, it links to marc (not gmane?) but finds no matches...
> > > >
> > > >   what mailing list post should it point to?
> > 
> > I found gmane to be much nicer to click through than marc.
> 
> IIRC I found no way to actually make a gmane link since it requires POST
> query for the searches or something.

The site seems to be down ATM, but it should be

http://search.gmane.org/search.php?group=gmane.comp.version-control.git&query=pasky

BTW how about calling the link "find mail"?  When I saw "mail" first time, 
I thought "oh, so I can mail that commitdiff to somebody?  Nice, let's 
try."

Ciao,
Dscho

Re: 'mail' link on http://repo.or.cz/w/git.git no workee?

[Johannes Schindelin]

Hi,

On Fri, 16 Jan 2009, Johannes Schindelin wrote:

> The site seems to be down ATM, but it should be
> 
> http://search.gmane.org/search.php?group=gmane.comp.version-control.git&query=pasky

FWIW, it is up again.

Ciao,
Dscho