From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Johan Herland <johan@herland.net>
Cc: Anders Melchiorsen <mail@cup.kalibalik.dk>,
git@vger.kernel.org, Jay Soffian <jaysoffian@gmail.com>,
Wincent Colaiuta <win@wincent.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
Sverre Rabbelier <srabbelier@gmail.com>,
Johannes Sixt <j.sixt@viscovery.net>
Subject: Re: [RFC PATCH] Make the rebase edit mode really end up in an edit state
Date: Fri, 16 Jan 2009 13:42:39 +0100 [thread overview]
Message-ID: <20090116124239.GA28870@neumann> (raw)
In-Reply-To: <200901161158.06828.johan@herland.net>
On Fri, Jan 16, 2009 at 11:58:06AM +0100, Johan Herland wrote:
> On Friday 16 January 2009, Anders Melchiorsen wrote:
> > Johan Herland wrote:
> > > amend e8902c1 Foo
> > >
> > > does a "pick" followed by "commit --amend" (for editing the commit
> > > message), followed by "rebase --continue".
> >
> > I do not think that "amend" is the best word for editing only the
> > commit message. A "commit --amend" can also make a new tree, so
> > reusing the word with a different meaning could be bad.
> >
> > As for alternatives, however, I can only come up with "copyedit", and
> > that is so horrible that I will not even propose it :-)
>
> "rephrase"?
This is the first one that I found acceptable.
'amend', 'modify' and 'edit' are just too close and non-intuitive:
they don't indicate _what_ will be amended, modified or edited at all.
'rephrase', on the other hand, is better, as you can rephrase a commit
message, but it's weird to say "rephrase the patch". But it's still
not as to-the-point as 'editmsg' (but that one has conflicting
abbreviation).
Best,
Gábor
next prev parent reply other threads:[~2009-01-16 12:44 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 0:27 [RFC PATCH] Make the rebase edit mode really end up in an edit state Anders Melchiorsen
2009-01-15 0:43 ` Junio C Hamano
2009-01-15 2:49 ` Boyd Stephen Smith Jr.
2009-01-15 4:10 ` Miles Bader
2009-01-15 5:00 ` Boyd Stephen Smith Jr.
2009-01-15 6:13 ` Junio C Hamano
2009-01-15 12:24 ` Johannes Schindelin
2009-01-15 15:35 ` SZEDER Gábor
2009-01-15 22:09 ` Junio C Hamano
2009-01-15 22:20 ` Sverre Rabbelier
2009-01-15 22:59 ` SZEDER Gábor
2009-01-16 0:11 ` Björn Steinbrink
2009-01-16 1:34 ` Johannes Schindelin
2009-01-18 1:24 ` Anders Melchiorsen
2009-01-16 1:09 ` Junio C Hamano
2009-01-16 12:10 ` Johannes Schindelin
2009-01-15 0:49 ` Stephan Beyer
2009-01-15 0:53 ` Johannes Schindelin
2009-01-15 7:35 ` Johannes Sixt
2009-01-15 10:01 ` Johan Herland
2009-01-15 11:52 ` Sverre Rabbelier
2009-01-15 12:36 ` Johannes Schindelin
2009-01-15 12:44 ` Adeodato Simó
2009-01-15 13:41 ` Johannes Schindelin
2009-01-15 13:41 ` Sverre Rabbelier
2009-01-15 13:57 ` Stephan Beyer
2009-01-15 14:02 ` Johannes Schindelin
2009-01-15 13:43 ` Adeodato Simó
2009-01-15 12:45 ` Sverre Rabbelier
2009-01-15 13:42 ` Johannes Schindelin
2009-01-15 13:56 ` Sverre Rabbelier
2009-01-15 16:59 ` Junio C Hamano
2009-01-15 17:16 ` Sverre Rabbelier
2009-01-15 18:21 ` Johannes Schindelin
2009-01-15 18:46 ` Johan Herland
2009-01-15 18:53 ` Anders Melchiorsen
2009-01-15 19:28 ` Johannes Schindelin
2009-01-15 19:27 ` Wincent Colaiuta
2009-01-15 20:26 ` Jay Soffian
2009-01-15 21:58 ` Wincent Colaiuta
2009-01-16 9:50 ` Johan Herland
2009-01-16 10:27 ` Anders Melchiorsen
2009-01-16 10:58 ` Johan Herland
2009-01-16 12:42 ` SZEDER Gábor [this message]
2009-01-16 12:57 ` Johannes Schindelin
2009-01-16 13:27 ` SZEDER Gábor
2009-01-16 14:28 ` Wincent Colaiuta
2009-01-16 13:12 ` Sverre Rabbelier
2009-01-16 17:26 ` Stephan Beyer
2009-01-16 21:06 ` Johannes Schindelin
2009-01-15 12:52 ` Pieter de Bie
2009-01-15 12:55 ` Sverre Rabbelier
2009-01-15 12:57 ` Pieter de Bie
2009-01-15 13:46 ` Björn Steinbrink
2009-01-15 13:54 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090116124239.GA28870@neumann \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=jaysoffian@gmail.com \
--cc=johan@herland.net \
--cc=johannes.schindelin@gmx.de \
--cc=mail@cup.kalibalik.dk \
--cc=srabbelier@gmail.com \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).