* Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote
[not found] <200901162254.58300.markus.heidelberg@web.de>
@ 2009-01-16 22:12 ` Shawn O. Pearce
2009-01-17 8:03 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Shawn O. Pearce @ 2009-01-16 22:12 UTC (permalink / raw)
To: Markus Heidelberg, Junio C Hamano; +Cc: git
Markus Heidelberg <markus.heidelberg@web.de> wrote:
>
> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
> I've just accidently read in the completion file itself, that
> Shawn is the maintainer, so I give it a third try. The first two
> haven't been sent to him.
Sorry, I must have missed the other two attempts. :-)
> contrib/completion/git-completion.bash | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 049ded0..6623344 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1384,7 +1384,7 @@ _git_config ()
>
> _git_remote ()
> {
> - local subcommands="add rm show prune update"
> + local subcommands="add rename rm show prune update"
> local subcommand="$(__git_find_subcommand "$subcommands")"
> if [ -z "$subcommand" ]; then
> __gitcomp "$subcommands"
> @@ -1392,7 +1392,7 @@ _git_remote ()
> fi
>
> case "$subcommand" in
> - rm|show|prune)
> + rename|rm|show|prune)
> __gitcomp "$(__git_remotes)"
> ;;
> update)
> --
> 1.6.1.35.g0c23
>
--
Shawn.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote
2009-01-16 22:12 ` [PATCH resend] bash completion: add 'rename' subcommand to git-remote Shawn O. Pearce
@ 2009-01-17 8:03 ` Junio C Hamano
2009-01-20 18:21 ` Markus Heidelberg
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2009-01-17 8:03 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: Markus Heidelberg, git
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Markus Heidelberg <markus.heidelberg@web.de> wrote:
>>
>> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
>> I've just accidently read in the completion file itself, that
>> Shawn is the maintainer, so I give it a third try. The first two
>> haven't been sent to him.
>
> Sorry, I must have missed the other two attempts. :-)
And I seem to have missed all three.
>
>
>> contrib/completion/git-completion.bash | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
>> index 049ded0..6623344 100755
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -1384,7 +1384,7 @@ _git_config ()
>>
>> _git_remote ()
>> {
>> - local subcommands="add rm show prune update"
>> + local subcommands="add rename rm show prune update"
>> local subcommand="$(__git_find_subcommand "$subcommands")"
>> if [ -z "$subcommand" ]; then
>> __gitcomp "$subcommands"
>> @@ -1392,7 +1392,7 @@ _git_remote ()
>> fi
>>
>> case "$subcommand" in
>> - rm|show|prune)
>> + rename|rm|show|prune)
>> __gitcomp "$(__git_remotes)"
>> ;;
>> update)
>> --
>> 1.6.1.35.g0c23
>>
>
> --
> Shawn.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote
2009-01-17 8:03 ` Junio C Hamano
@ 2009-01-20 18:21 ` Markus Heidelberg
2009-01-21 10:26 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Markus Heidelberg @ 2009-01-20 18:21 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Shawn O. Pearce, git
Junio C Hamano, 17.01.2009:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
> > Markus Heidelberg <markus.heidelberg@web.de> wrote:
> >>
> >> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
> >
> > Acked-by: Shawn O. Pearce <spearce@spearce.org>
> >
> >> I've just accidently read in the completion file itself, that
> >> Shawn is the maintainer, so I give it a third try. The first two
> >> haven't been sent to him.
> >
> > Sorry, I must have missed the other two attempts. :-)
>
> And I seem to have missed all three.
I really don't like to bother you again, but compared to the inclusion
of the other patches, I guess you have forgotten the third try of this
patch.
Thus this fourth try :)
Markus
> >> contrib/completion/git-completion.bash | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> >> index 049ded0..6623344 100755
> >> --- a/contrib/completion/git-completion.bash
> >> +++ b/contrib/completion/git-completion.bash
> >> @@ -1384,7 +1384,7 @@ _git_config ()
> >>
> >> _git_remote ()
> >> {
> >> - local subcommands="add rm show prune update"
> >> + local subcommands="add rename rm show prune update"
> >> local subcommand="$(__git_find_subcommand "$subcommands")"
> >> if [ -z "$subcommand" ]; then
> >> __gitcomp "$subcommands"
> >> @@ -1392,7 +1392,7 @@ _git_remote ()
> >> fi
> >>
> >> case "$subcommand" in
> >> - rm|show|prune)
> >> + rename|rm|show|prune)
> >> __gitcomp "$(__git_remotes)"
> >> ;;
> >> update)
> >> --
> >> 1.6.1.35.g0c23
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote
2009-01-20 18:21 ` Markus Heidelberg
@ 2009-01-21 10:26 ` Junio C Hamano
2009-01-21 22:59 ` Markus Heidelberg
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2009-01-21 10:26 UTC (permalink / raw)
To: markus.heidelberg; +Cc: Shawn O. Pearce, git
Markus Heidelberg <markus.heidelberg@web.de> writes:
> Junio C Hamano, 17.01.2009:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>>
>> > Markus Heidelberg <markus.heidelberg@web.de> wrote:
>> >>
>> >> Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
>> >
>> > Acked-by: Shawn O. Pearce <spearce@spearce.org>
>> >
>> >> I've just accidently read in the completion file itself, that
>> >> Shawn is the maintainer, so I give it a third try. The first two
>> >> haven't been sent to him.
>> >
>> > Sorry, I must have missed the other two attempts. :-)
>>
>> And I seem to have missed all three.
>
> I really don't like to bother you again, but compared to the inclusion
> of the other patches, I guess you have forgotten the third try of this
> patch.
>
> Thus this fourth try :)
I did not mean that I forgot by the above "I seem to have missed".
Literally none of your three attempts seem to have reached me. I can
guess what you wrote from the _included_ text in Shawn's response, but
that is not a good/right place for me to pick up a patch from, is it?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] bash completion: add 'rename' subcommand to git-remote
2009-01-21 10:26 ` Junio C Hamano
@ 2009-01-21 22:59 ` Markus Heidelberg
0 siblings, 0 replies; 6+ messages in thread
From: Markus Heidelberg @ 2009-01-21 22:59 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Shawn O. Pearce, git
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Acked-by: Shawn O. Pearce <spearce@spearce.org>
---
> > I really don't like to bother you again, but compared to the inclusion
> > of the other patches, I guess you have forgotten the third try of this
> > patch.
> >
> > Thus this fourth try :)
>
> I did not mean that I forgot by the above "I seem to have missed".
> Literally none of your three attempts seem to have reached me.
Ah, OK. With "missed" I thought you have just overlooked them.
> I can
> guess what you wrote from the _included_ text in Shawn's response, but
> that is not a good/right place for me to pick up a patch from, is it?
No, it isn't.
next mail:
I just don't get it. The previous mail, I sent three a half hours ago,
didn't reach the list either. Am I doing anything wrong? I looked at
the archives: the first two got to the list, the 3rd (with the Acked-by
from Shawn) and 4th didn't. Now this is the 5th. I can't remember any
such problems with mail delivery.
contrib/completion/git-completion.bash | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3ce6de2..f2d6cad 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1391,7 +1391,7 @@ _git_config ()
_git_remote ()
{
- local subcommands="add rm show prune update"
+ local subcommands="add rename rm show prune update"
local subcommand="$(__git_find_subcommand "$subcommands")"
if [ -z "$subcommand" ]; then
__gitcomp "$subcommands"
@@ -1399,7 +1399,7 @@ _git_remote ()
fi
case "$subcommand" in
- rm|show|prune)
+ rename|rm|show|prune)
__gitcomp "$(__git_remotes)"
;;
update)
--
1.6.1.227.gad9c0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH, resend] bash completion: add 'rename' subcommand to git-remote
@ 2009-01-08 18:53 Markus Heidelberg
0 siblings, 0 replies; 6+ messages in thread
From: Markus Heidelberg @ 2009-01-08 18:53 UTC (permalink / raw)
To: gitster; +Cc: git
Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
---
contrib/completion/git-completion.bash | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 187f3de..4717c93 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1369,7 +1369,7 @@ _git_config ()
_git_remote ()
{
- local subcommands="add rm show prune update"
+ local subcommands="add rename rm show prune update"
local subcommand="$(__git_find_subcommand "$subcommands")"
if [ -z "$subcommand" ]; then
__gitcomp "$subcommands"
@@ -1377,7 +1377,7 @@ _git_remote ()
fi
case "$subcommand" in
- rm|show|prune)
+ rename|rm|show|prune)
__gitcomp "$(__git_remotes)"
;;
update)
--
1.6.1.35.g0c23
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-01-21 23:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200901162254.58300.markus.heidelberg@web.de>
2009-01-16 22:12 ` [PATCH resend] bash completion: add 'rename' subcommand to git-remote Shawn O. Pearce
2009-01-17 8:03 ` Junio C Hamano
2009-01-20 18:21 ` Markus Heidelberg
2009-01-21 10:26 ` Junio C Hamano
2009-01-21 22:59 ` Markus Heidelberg
2009-01-08 18:53 [PATCH, " Markus Heidelberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).