git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Adeodato Simó" <dato@net.com.org.es>
To: git@vger.kernel.org
Subject: [RFC] Making format-patch output better when blank line is missing?
Date: Sat, 17 Jan 2009 13:35:45 +0100	[thread overview]
Message-ID: <20090117123545.GA22842@chistera.yi.org> (raw)

Hello,

I'm using git-format-patch to send commit diff emails, and it was
recently brought to my atention that if a commit message consists
entirely in a paragraph with no blank lines (particluarly, no blank line
after the first line, which is not a summary but just the first line of
the paragraph), git-format-patch will place all the commit message in
the Subject, which is inconvenient to read.

Do you think it would be good to have format-patch do something like
this in this case?:

    Subject: [PATCH] This commit introduces a new function bla() that [...]

    [...] makes it possible to apply the frobniz operation to objects
    that don't bla bla bla bla.

(I realize that, with this, the applying logic would have to learn about
it. Hm.)

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
- I love you, Shirley, I'm not ashamed to say.
- If you love me, then you'll want me to be happy. Even if I'm not with you.
- I don't love you that much.
                -- Denny Crane and Shirley Schmidt

             reply	other threads:[~2009-01-17 12:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-17 12:35 Adeodato Simó [this message]
2009-01-17 15:47 ` [RFC] Making format-patch output better when blank line is missing? Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090117123545.GA22842@chistera.yi.org \
    --to=dato@net.com.org.es \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).