git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] bash: offer to show (un)staged changes
Date: Sun, 18 Jan 2009 03:06:38 +0100	[thread overview]
Message-ID: <200901180306.40700.trast@student.ethz.ch> (raw)
In-Reply-To: <7vwsct2xd1.fsf@gitster.siamese.dyndns.org>

[-- Attachment #1: Type: text/plain, Size: 716 bytes --]

Junio C Hamano wrote:
> Thomas Rast <trast@student.ethz.ch> writes:
> 
> > +		if test ! -z "$GIT_PS1_EXPENSIVE"; then
> > +			git update-index --refresh >/dev/null 2>&1 || w="*"
> 
> This makes the feature unavailable for people who care about the stat
> dirtiness and explicitly set diff.autorefreshindex to false, doesn't it?

True, and I admit I didn't know there was an option to change that.
OTOH git-diff-files doesn't normally update the index even if the
option is set.  Should I ask 'git diff --exit-code --raw' or some such
instead?

(Why would people want to keep the stat info dirty even though there
may not have been any changes?)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch




[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-01-18  2:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-18  0:56 [PATCH] bash: offer to show (un)staged changes Thomas Rast
2009-01-18  1:53 ` Junio C Hamano
2009-01-18  2:06   ` Thomas Rast [this message]
2009-01-19 17:29   ` Shawn O. Pearce
2009-01-19 18:00     ` Martin Langhoff
2009-01-19 18:11       ` Shawn O. Pearce
2009-01-19 18:28         ` Mike Hommey
2009-01-19 18:42         ` Martin Langhoff
2009-01-19 19:06       ` Boyd Stephen Smith Jr.
2009-01-19 19:12         ` Martin Langhoff
2009-01-19 19:01     ` Boyd Stephen Smith Jr.
2009-01-19 21:38     ` [PATCH v2] " Thomas Rast
2009-02-01 22:13       ` Thomas Rast
2009-02-01 22:29         ` Shawn O. Pearce
2009-02-03  9:20           ` [PATCH v3] " Thomas Rast
2009-02-03 18:11             ` Shawn O. Pearce
2009-02-01 22:48     ` [PATCH] " Tuncer Ayaz
2009-02-01 23:43       ` Junio C Hamano
2009-02-02  0:50         ` Tuncer Ayaz
2009-02-02 19:31           ` Tuncer Ayaz
2009-01-18  2:13 ` Junio C Hamano
2009-01-18  2:32   ` Thomas Rast

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901180306.40700.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).