From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Beyer Subject: Re: [PATCH/RFC] git-am: Make it easier to see which patch failed Date: Sun, 18 Jan 2009 17:53:26 +0100 Message-ID: <20090118165326.GM11992@leksak.fem-net> References: <636ecac0901160518o16706bbia9acaf09fdf92946@mail.gmail.com> <636ecac0901160634r586c72a0r9bb63c6f019f5bff@mail.gmail.com> <7vhc3x1874.fsf@gitster.siamese.dyndns.org> <20090118094113.GE11992@leksak.fem-net> <20090118153928.GA16664@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff King , Junio C Hamano , Jonas =?iso-8859-1?Q?Flod=E9n?= , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Sun Jan 18 17:55:07 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LOavR-0006YO-7q for gcvg-git-2@gmane.org; Sun, 18 Jan 2009 17:55:05 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757738AbZARQxm (ORCPT ); Sun, 18 Jan 2009 11:53:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759361AbZARQxk (ORCPT ); Sun, 18 Jan 2009 11:53:40 -0500 Received: from mail.gmx.net ([213.165.64.20]:57005 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761044AbZARQxk (ORCPT ); Sun, 18 Jan 2009 11:53:40 -0500 Received: (qmail invoked by alias); 18 Jan 2009 16:53:37 -0000 Received: from q137.fem.tu-ilmenau.de (EHLO leksak.fem-net) [141.24.46.137] by mail.gmx.net (mp015) with SMTP; 18 Jan 2009 17:53:37 +0100 X-Authenticated: #1499303 X-Provags-ID: V01U2FsdGVkX1/VT1MhZIDV+39nCouuZTQVCJipr8ZAmgUh+B+hnu 5vuKQsflWP2Jzl Received: from sbeyer by leksak.fem-net with local (Exim 4.69) (envelope-from ) id 1LOatr-0005pW-08; Sun, 18 Jan 2009 17:53:27 +0100 Content-Disposition: inline In-Reply-To: X-Y-GMX-Trusted: 0 X-FuHaFi: 0.48 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Hi, Johannes Schindelin wrote: > On Sun, 18 Jan 2009, Jeff King wrote: > > > On Sun, Jan 18, 2009 at 10:41:13AM +0100, Stephan Beyer wrote: > > > > > > Looks sane except that I do not think you need printf nor the leading > > > > blank line, i.e. > > > > > > > > echo "Patch failed at $msgnum ($FIRSTLINE)" > > > > > > Hmm, IIRC if $FIRSTLINE contains \n or something like that, it will > > > interpret this as newline in some shell/echo implementations. > > > > > > So printf "...%s..." "$FOO" is always sane for user input. > > > > Yes, I'm surprised Junio doesn't remember the mass conversions we > > already had to do (4b7cc26a and 293623ed). But looking at the date, I > > guess it _has_ been a year and a half. :) > > Hey, be nice to Junio. Have you seen the amount of mails on this list > recently? I think Junio's the only one really reading all of them; even > if you were right, he would be entitled to a nicer reminder. I had almost written the same text but then I thought Jeff did not mean it bad, he was just surprised. > But you are wrong. And Stephan is wrong, too. > > The name "FIRSTLINE" suggests that it is indeed a first line, and > consequently cannot contain a newline. > > And indeed, it is defined as > > FIRSTLINE=$(sed 1q "$dotest/final-commit") > > Just do the following in any of your favorite shells: > > $ FIRSTLINE=$(sed 1q README) > $ echo "$FIRSTLINE." > > You'll find that the "." is not in a new line. I have to disagree: $ cat newline foo\nbar $ FIRSTLINE=$(sed 1q newline) $ echo "$FIRSTLINE." foo bar. $ exit > And I know that we relied on that behavior for an eternity. Where? We should perhaps fix it then. Regards, Stephan -- Stephan Beyer , PGP 0x6EDDD207FCC5040F