From: Mike Hommey <mh@glandium.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [WIP Patch 02/12] Some cleanup in get_refs_via_curl()
Date: Sun, 18 Jan 2009 20:19:28 +0100 [thread overview]
Message-ID: <20090118191928.GA23108@glandium.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901182005230.3586@pacific.mpi-cbg.de>
On Sun, Jan 18, 2009 at 08:06:17PM +0100, Johannes Schindelin wrote:
> Hi,
>
> On Sun, 18 Jan 2009, Mike Hommey wrote:
>
> > diff --git a/transport.c b/transport.c
> > index 56831c5..6919ff1 100644
> > --- a/transport.c
> > +++ b/transport.c
> > @@ -508,6 +508,8 @@ static struct ref *get_refs_via_curl(struct transport *transport)
> > free(ref);
> > }
> >
> > + http_cleanup();
> > + free(refs_url);
> > return refs;
> > }
>
> You cannot http_cleanup() here, as http-push calls that function, but
> continues to want to use curl.
Are you really sure? It doesn't seem so, to me.
Mike
next prev parent reply other threads:[~2009-01-18 19:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 15:36 [PATCH] http-push: fix off-by-path_len Johannes Schindelin
2009-01-17 15:40 ` Where's Nick?, was " Johannes Schindelin
2009-01-17 15:41 ` [PATCH] t5540: clarify that http-push does not handle packed-refs on the remote Johannes Schindelin
2009-01-18 7:49 ` [PATCH] http-push: fix off-by-path_len Mike Hommey
2009-01-18 8:04 ` [WIP Patch 00/12] Refactoring the http API Mike Hommey
2009-01-18 8:04 ` [WIP Patch 01/12] Don't expect verify_pack() callers to set pack_size Mike Hommey
2009-01-18 8:04 ` [WIP Patch 02/12] Some cleanup in get_refs_via_curl() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 03/12] Two new functions for the http API Mike Hommey
2009-01-18 8:04 ` [WIP Patch 04/12] Use the new http API in http_fetch_ref() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 05/12] Use the new http API in get_refs_via_curl() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 06/12] Use the new http API in http-walker.c:fetch_indices() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 07/12] Use the new http API in http-push.c:fetch_indices() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 08/12] Use the new http API in update_remote_info_refs() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 09/12] Use the new http API in fetch_symref() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 10/12] Use the new http API in http-walker.c:fetch_index() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 11/12] Use the new http API in http-push.c:fetch_index() Mike Hommey
2009-01-18 8:04 ` [WIP Patch 12/12] Use the new http API in http-walker.c:fetch_pack() Mike Hommey
2009-01-18 15:18 ` [WIP Patch 08/12] Use the new http API in update_remote_info_refs() Johannes Schindelin
2009-01-18 19:23 ` Mike Hommey
2009-01-18 15:14 ` [WIP Patch 07/12] Use the new http API in http-push.c:fetch_indices() Johannes Schindelin
2009-01-18 15:12 ` [WIP Patch 05/12] Use the new http API in get_refs_via_curl() Johannes Schindelin
2009-01-18 15:10 ` [WIP Patch 04/12] Use the new http API in http_fetch_ref() Johannes Schindelin
2009-01-18 19:21 ` Mike Hommey
2009-01-18 15:03 ` [WIP Patch 03/12] Two new functions for the http API Johannes Schindelin
2009-01-18 19:06 ` [WIP Patch 02/12] Some cleanup in get_refs_via_curl() Johannes Schindelin
2009-01-18 19:11 ` Johannes Schindelin
2009-01-18 19:30 ` Mike Hommey
2009-01-18 21:09 ` Johannes Schindelin
2009-01-18 19:19 ` Mike Hommey [this message]
2009-01-18 21:10 ` Johannes Schindelin
2009-01-18 8:30 ` [WIP Patch 00/12] Refactoring the http API Junio C Hamano
2009-01-18 9:12 ` Mike Hommey
2009-01-18 11:29 ` Boyd Stephen Smith Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118191928.GA23108@glandium.org \
--to=mh@glandium.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).