From: "Adeodato Simó" <dato@net.com.org.es>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC] shortlog: add option to group together different names/emails of an author
Date: Mon, 19 Jan 2009 15:11:07 +0100 [thread overview]
Message-ID: <20090119141107.GA27992@chistera.yi.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901191445340.3586@pacific.mpi-cbg.de>
* Johannes Schindelin [Mon, 19 Jan 2009 14:49:39 +0100]:
> > Ping? I realize this may be seen as a big patch dropped out of the blue,
> > but I would very much like to hear some comments on at least the feature
> > itself, which should not take more than reading the commit message.
> This is such a huge change, for something that not many people want.
> Actually, you seem to be the first.
That's, uhm, sad. (I don't really buy the "not many people want it,
hence we should not include it" argument, unless by people you mean
"people who could do a review". No hard feelings, though.)
> And you could just as well write a script that takes the output of
> $ git log --pretty=format:%an\ %ae --all | sort | uniq
> and constructs a valid .mailmap. That would also have the advantage that
> you do not need to perform the analysis each time you call Git.
No, not really. As mentioned in the commit message, .mailmap files don't
help when you invoke shortlog with -e, and different email addresses for
an author are involved.
> All these reasons make me believe that your patch should not be applied.
Okay, I'll let go.
Cheers,
--
Adeodato Simó dato at net.com.org.es
Debian Developer adeodato at debian.org
Mankind are very odd creatures: one half censure what they practice, the
other half practice what they censure; the rest always say and do as
they ought.
-- Michel de Montaigne
next prev parent reply other threads:[~2009-01-19 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 15:16 [PATCH/RFC] shortlog: add option to group together different names/emails of an author Adeodato Simó
2009-01-19 13:43 ` Adeodato Simó
2009-01-19 13:49 ` Johannes Schindelin
2009-01-19 14:11 ` Adeodato Simó [this message]
2009-01-19 14:29 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119141107.GA27992@chistera.yi.org \
--to=dato@net.com.org.es \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox