From: Jeff King <peff@peff.net>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Rename detection: Avoid repeated filespec population
Date: Wed, 21 Jan 2009 08:32:11 -0500 [thread overview]
Message-ID: <20090121133211.GA20360@coredump.intra.peff.net> (raw)
In-Reply-To: <20090121125619.GA523@atjola.homenet>
On Wed, Jan 21, 2009 at 01:56:19PM +0100, Björn Steinbrink wrote:
> Another possible solution would be to free the blob data only after the
> loop in diffcore_rename has finished, but that's obviously quite bad WRT
> memory consumption. :-)
Yeah, and it doesn't have the (admittedly smaller, but still there)
optimization of not loading the blob data at all if we will never need
to.
> Anyway, too late, yesterday's attempts 6 to 10 at writing a better
> commit message didn't work out either, and Junio has applied the patch
> by now.
I think that's fine. My message was more about convincing myself that
your change was the right thing (and hopefully helped convince others,
too).
-Peff
next prev parent reply other threads:[~2009-01-21 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 15:59 [PATCH] Rename detection: Avoid repeated filespec population Björn Steinbrink
2009-01-20 21:27 ` Jeff King
2009-01-20 22:12 ` Jeff King
2009-01-21 12:56 ` Björn Steinbrink
2009-01-21 13:32 ` Jeff King [this message]
2009-01-21 10:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090121133211.GA20360@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).