From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Subject: [PATCH v2 1/5] Windows: Fix signal numbers
Date: Thu, 22 Jan 2009 00:57:34 -0500 [thread overview]
Message-ID: <20090122055734.GA30133@coredump.intra.peff.net> (raw)
In-Reply-To: <20090122042643.GB31427@coredump.intra.peff.net>
From: Johannes Sixt <j6t@kdbg.org>
We had defined some SIG_FOO macros that appear in the code, but that are
not supported on Windows, in order to make the code compile. But a
subsequent change will assert that a signal number is non-zero. We now
use the signal numbers that are commonly used on POSIX systems.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Jeff King <peff@peff.net>
---
This is necessary to avoid violating sigchain assertions in the next
patch.
compat/mingw.h | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/compat/mingw.h b/compat/mingw.h
index 4f275cb..a255898 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -21,12 +21,12 @@ typedef int pid_t;
#define WEXITSTATUS(x) ((x) & 0xff)
#define WIFSIGNALED(x) ((unsigned)(x) > 259)
-#define SIGKILL 0
-#define SIGCHLD 0
-#define SIGPIPE 0
-#define SIGHUP 0
-#define SIGQUIT 0
-#define SIGALRM 100
+#define SIGHUP 1
+#define SIGQUIT 3
+#define SIGKILL 9
+#define SIGPIPE 13
+#define SIGALRM 14
+#define SIGCHLD 17
#define F_GETFD 1
#define F_SETFD 2
--
1.6.1.403.g6c435
next prev parent reply other threads:[~2009-01-22 5:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 3:55 What's cooking in git.git (Jan 2009, #05; Wed, 21) Junio C Hamano
2009-01-22 4:26 ` Jeff King
2009-01-22 5:57 ` Jeff King [this message]
2009-01-22 5:59 ` [PATCH v2 2/5] diff: refactor tempfile cleanup handling Jeff King
2009-01-22 6:02 ` [PATCH v2 3/5] chain kill signals for cleanup functions Jeff King
2009-01-30 7:55 ` Jeff King
2009-01-30 8:13 ` Johannes Sixt
2009-01-30 8:21 ` Jeff King
2009-01-31 0:28 ` Junio C Hamano
2009-01-31 1:44 ` Jeff King
2009-01-31 6:50 ` Jeff King
2009-02-01 1:58 ` Junio C Hamano
2009-01-22 6:03 ` [PATCH v2 4/5] refactor signal handling " Jeff King
2009-01-22 6:03 ` [PATCH v2 5/5] pager: do wait_for_pager on signal death Jeff King
2009-01-22 5:13 ` What's cooking in git.git (Jan 2009, #05; Wed, 21) Johannes Schindelin
2009-01-31 6:45 ` Sam Vilain
2009-01-31 7:36 ` Jeff King
2009-02-01 2:39 ` [PATCH] split notes [was: Re: What's cooking in git.git (Jan 2009, #05; Wed, 21)] Sam Vilain
2009-02-01 3:09 ` Sam Vilain
2009-02-01 12:01 ` Jakub Narebski
2009-01-22 5:21 ` What's cooking in git.git (Jan 2009, #05; Wed, 21) Boyd Stephen Smith Jr.
2009-01-23 6:23 ` Junio C Hamano
2009-01-27 1:43 ` Boyd Stephen Smith Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090122055734.GA30133@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).