From: Miklos Vajna <vmiklos@frugalware.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Allow cloning an empty repository
Date: Sat, 24 Jan 2009 00:05:20 +0100 [thread overview]
Message-ID: <20090123230520.GL21473@genesis.frugalware.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901230333060.3586@pacific.mpi-cbg.de>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Fri, Jan 23, 2009 at 03:42:24AM +0100, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > > I am mostly worried about a failure case (connected but couldn't get
> > > the refs, or perhaps connection failed to start). If you get a NULL
> > > in such a case you may end up saying "oh you cloned a void" when you
> > > should say "nah, such a remote repository does not exist".
> >
> > Yes, this was my concern as well.
>
> From what I can see in get_remote_heads(), the native protocols would
> die(), as would rsync().
>
> HTTP transport, however, would not die() on connection errors, from my
> cursory look.
I'm not familiar with the HTTP code, either, but here is the call stack
I see:
- builtin-clone calls transport_get_remote_refs()
- that will call transport->get_refs_list()
- that will call get_refs_via_curl()
- that die()s on error, does not use return error()
Have I missed something?
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-23 23:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 0:07 [PATCH] Allow cloning an empty repository Sverre Rabbelier
2009-01-23 1:24 ` Junio C Hamano
2009-01-23 1:46 ` Sverre Rabbelier
2009-01-23 2:42 ` Johannes Schindelin
2009-01-23 2:47 ` Sverre Rabbelier
2009-01-23 3:20 ` Johannes Schindelin
2009-01-23 16:55 ` Miklos Vajna
2009-01-23 20:05 ` Johannes Schindelin
2009-01-23 22:32 ` Jeff King
2009-01-23 22:34 ` Sverre Rabbelier
2009-01-23 22:37 ` Jeff King
2009-01-23 22:39 ` Sverre Rabbelier
2009-01-24 0:28 ` Johannes Schindelin
2009-01-23 21:55 ` Mike Hommey
2009-01-24 0:26 ` http fixes, was " Johannes Schindelin
2009-01-24 9:39 ` Sverre Rabbelier
2009-01-23 23:05 ` Miklos Vajna [this message]
2009-01-24 0:33 ` Johannes Schindelin
2009-01-24 0:42 ` Sverre Rabbelier
2009-01-25 0:49 ` Miklos Vajna
2009-01-25 0:55 ` Sverre Rabbelier
2009-01-25 5:05 ` Junio C Hamano
2009-01-25 18:33 ` Sverre Rabbelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123230520.GL21473@genesis.frugalware.org \
--to=vmiklos@frugalware.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).