From: Matthew Ogilvie <mmogilvi_git@miniinfo.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 08/10] run test suite without dashed git-commands in PATH
Date: Mon, 26 Jan 2009 23:13:49 -0700 [thread overview]
Message-ID: <20090127061349.GA2417@comcast.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0901261201470.14855@racer>
On Mon, Jan 26, 2009 at 12:06:08PM +0100, Johannes Schindelin wrote:
> So maybe I was wrong to assume that this is cvsserver specific, but then,
> you made that mistake rather easy to make.
Yes, in retrospect I probably should have split off patches 6, 7,
8, and maybe 5 (5-7 fix issues that patch 8 exposes in the test suite)
into a separate patch series. When or if a v2 is needed, should
I split them off then?
> > 4. The test-bin-wrapper.sh script does not actually need to set
> > environment variables (GIT_EXEC_DIT and templates) for purposes
> > of this patch. But my thought was that in this form you could
> > run things straight out of the test-bin directory to manually try
> > out new code without needing to actually install a build or mess
> > with the environment variables yourself. It could also be
> > extended to handle other global wrapper needs relatively easily,
> > such as valgrind.
>
> Umm.
>
> You missed the valgrind patch series.
Actually, I'm (poorly) alluding to some comments in the original patch
8 email, where I pointed out an expected conflict with the valgrind
patches. To briefly recap, there are at least 3 possible strategies
of resolving such a conflict, and I'm not sure which makes the most
sense: Keep valgrind design, and extend it with limited bindir
support. Keep limited bindir design and extend it with valgrind
support. Or keep both, and have the runtime setup logic make
them mutually exclusive.
--
Matthew Ogilvie [mmogilvi_git@miniinfo.net]
next prev parent reply other threads:[~2009-01-27 6:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 23:43 [PATCH 00/10] Misc. cvsserver, dashless, and test suite patches Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 01/10] cvsserver: removed unused sha1Or-k mode from kopts_from_path Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 02/10] cvsserver: add comments about database schema/usage Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 03/10] cvsserver: remove unused functions _headrev and gethistory Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 04/10] git-shell: allow running git-cvsserver, not just cvs Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 05/10] cvsserver: run dashless "git command"s to access plumbing Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 06/10] t2300: use documented technique to invoke git-sh-setup Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 07/10] t3409: use dashless "git commit" instead of "git-commit" Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 08/10] run test suite without dashed git-commands in PATH Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 09/10] Revert "adapt git-cvsserver manpage to dash-free syntax" Matthew Ogilvie
2009-01-24 23:43 ` [PATCH 10/10] cvsserver doc: emphasize using CVS_SERVER= phrase within CVSROOT Matthew Ogilvie
2009-01-25 1:59 ` [PATCH 08/10] run test suite without dashed git-commands in PATH Johannes Schindelin
2009-01-26 6:40 ` Matthew Ogilvie
2009-01-26 11:06 ` Johannes Schindelin
2009-01-27 6:13 ` Matthew Ogilvie [this message]
2009-01-25 1:53 ` [PATCH 04/10] git-shell: allow running git-cvsserver, not just cvs Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127061349.GA2417@comcast.net \
--to=mmogilvi_git@miniinfo.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).