From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff King <peff@peff.net>
Subject: Re: [PATCHv2 3/4] run-command: help callers distinguish errors
Date: Wed, 28 Jan 2009 02:47:33 -0500
Message-ID: <20090128074732.GC31951@coredump.intra.peff.net>
References: <20090128073059.GD19165@coredump.intra.peff.net> <20090128073639.GC31884@coredump.intra.peff.net> <20090128074334.GB31951@coredump.intra.peff.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
To: Junio C Hamano <gitster@pobox.com>
X-From: git-owner@vger.kernel.org Wed Jan 28 08:49:01 2009
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1LS5AS-0001u5-ME
	for gcvg-git-2@gmane.org; Wed, 28 Jan 2009 08:49:01 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752320AbZA1Hrf (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Wed, 28 Jan 2009 02:47:35 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752250AbZA1Hrf
	(ORCPT <rfc822;git-outgoing>); Wed, 28 Jan 2009 02:47:35 -0500
Received: from peff.net ([208.65.91.99]:38924 "EHLO peff.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752149AbZA1Hrf (ORCPT <rfc822;git@vger.kernel.org>);
	Wed, 28 Jan 2009 02:47:35 -0500
Received: (qmail 19759 invoked by uid 107); 28 Jan 2009 07:47:43 -0000
Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2)
    by peff.net (qpsmtpd/0.40) with (AES128-SHA encrypted) SMTP; Wed, 28 Jan 2009 02:47:43 -0500
Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Wed, 28 Jan 2009 02:47:33 -0500
Content-Disposition: inline
In-Reply-To: <20090128074334.GB31951@coredump.intra.peff.net>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/107499>

On Wed, Jan 28, 2009 at 02:43:34AM -0500, Jeff King wrote:

> On Wed, Jan 28, 2009 at 02:36:39AM -0500, Jeff King wrote:
> 
> > +#define IS_RUN_COMMAND_ERR(x) (x >= ERR_RUN_COMMAND_FORK)
> 
> <sigh> This should be "<= -ERR_RUN_COMMAND_FORK", since we expect the
> negated status.
> 
> Maybe it is time I wrote a test for a failed external.

Hmm. Actually, it is hard to write a test case for this; it only
triggers if we actually have an error running a program, like fork()
failing.

-Peff