From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [JGIT PATCH] Add getTaggerIdent, getShortMessage, getFullMessage to RevTag
Date: Wed, 28 Jan 2009 21:10:48 +0100 [thread overview]
Message-ID: <200901282110.48899.robin.rosenberg.lists@dewire.com> (raw)
In-Reply-To: <1233117316-3291-1-git-send-email-spearce@spearce.org>
onsdag 28 januari 2009 05:35:16 skrev Shawn O. Pearce:
> These methods make the RevTag API more like the RevCommit API, such
> that it is more consistent for applications to access the "fields"
> of a tag object in the same way that they access the fields of any
> commit object.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>
> Actually, this has also gone through Gerrit2. If you want to see
> what the same patch looks like (just for fun):
The reviewer is biased :) Where are the unit tests?
I'm kind of surprised you did not optimized skipping past the object header,
like the parents are skipped when parsing commits.
-- robin
next prev parent reply other threads:[~2009-01-28 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 4:35 [JGIT PATCH] Add getTaggerIdent, getShortMessage, getFullMessage to RevTag Shawn O. Pearce
2009-01-28 20:10 ` Robin Rosenberg [this message]
2009-01-31 0:56 ` [PATCH v2] " Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901282110.48899.robin.rosenberg.lists@dewire.com \
--to=robin.rosenberg.lists@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).