From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] symbolic ref: refuse non-ref targets in HEAD
Date: Thu, 29 Jan 2009 03:34:37 -0500 [thread overview]
Message-ID: <20090129083437.GA6297@coredump.intra.peff.net> (raw)
In-Reply-To: <20090129080145.GA777@coredump.intra.peff.net>
On Thu, Jan 29, 2009 at 03:01:45AM -0500, Jeff King wrote:
> > In addition, perhaps it may make sense to use test_create_repo to go one
> > level deeper before starting to play around, so that trash directory's
> > repository will prevent you from going any further up.
>
> That sort of helps, but only by luck. Each test kills off one layer of
> repo. So the first one kills the test_create_repo, and the second one
> kills the trash directory. Adding another test would kill off the main
> repo. :) So you have to do something per-test. I'll do that in the
> re-roll.
It occurs to me you perhaps did mean to do something per-test, like:
test_create_repo foo && (cd foo && do_the_actual_test)
That would work, too.
-Peff
prev parent reply other threads:[~2009-01-29 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 4:52 [PATCH] symbolic ref: refuse non-ref targets in HEAD Jeff King
2009-01-29 7:53 ` Junio C Hamano
2009-01-29 8:01 ` Jeff King
2009-01-29 8:30 ` [PATCH 1/2] validate_headref: tighten ref-matching to just branches Jeff King
2009-01-29 8:33 ` [PATCH 2/2] symbolic ref: refuse non-ref targets in HEAD Jeff King
2009-01-29 8:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129083437.GA6297@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).