From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] push: Learn to set up branch tracking with '--track'
Date: Fri, 30 Jan 2009 00:09:25 -0500 [thread overview]
Message-ID: <20090130050925.GA18809@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0901300127450.3586@pacific.mpi-cbg.de>
On Fri, Jan 30, 2009 at 01:28:38AM +0100, Johannes Schindelin wrote:
> > Something like the patch below (which is obviously missing all of the
> > infrastructure for doing this optionally, but is meant to illustrate
> > what I'm talking about).
>
> Except that you miss http:// and rsync:// protocols. Those were the
> reasons I did not touch send-pack.
You didn't comment on the part of my email where I said exactly that,
but that I think this is still the right path forward.
Pushing through those protocols is sorely in need of update (actually,
I thought rsync was all but dead at this point). But http push is
missing the update of tracking refs, the usual status output (it still
has the "Maybe you are not up-to-date and need to pull first?" message
that was removed from send-pack a year and a half ago), and who knows
what other tweaks made to do_send_pack (which it appears to have been
copy-and-pasted from in 2006) in the last few years.
So either we don't care about http-push being consistent with send-pack,
and it is OK to have this feature in one but not the other. Or we do,
and we really need to clean up the current divergence.
-Peff
next prev parent reply other threads:[~2009-01-30 5:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1233236267u.git.johannes.schindelin@gmx.de>
2009-01-29 13:38 ` [PATCH] push: Learn to set up branch tracking with '--track' Johannes Schindelin
2009-01-29 13:51 ` Sverre Rabbelier
2009-01-29 14:05 ` Johannes Schindelin
2009-01-29 14:02 ` Johannes Schindelin
2009-01-29 22:33 ` Jeff King
2009-01-29 23:17 ` Jeff King
2009-01-30 0:28 ` Johannes Schindelin
2009-01-30 5:09 ` Jeff King [this message]
2009-01-30 15:58 ` Johannes Schindelin
2009-01-30 16:22 ` Jeff King
2009-01-30 17:05 ` Johannes Schindelin
2009-02-02 13:16 ` Jeff King
2009-02-02 13:52 ` Johannes Schindelin
2009-02-06 14:10 ` Jeff King
2009-02-06 14:54 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130050925.GA18809@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).