From: Jeff King <peff@peff.net>
To: Geoffrey Thomas <geofft@MIT.EDU>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] utf8: add utf8_strwidth()
Date: Sat, 31 Jan 2009 03:56:52 -0500 [thread overview]
Message-ID: <20090131085652.GA6484@coredump.intra.peff.net> (raw)
In-Reply-To: <alpine.DEB.2.00.0901310348000.3373@vinegar-pot.mit.edu>
On Sat, Jan 31, 2009 at 03:51:48AM -0500, Geoffrey Thomas wrote:
> On Sat, 31 Jan 2009, Jeff King wrote:
>> I know next to nothing about our encoding functions, but this seems
>> suspiciously similar to utf8_width in utf8.c. There is also a
>> git_wcwidth, but I don't know how they relate.
>
> git_wcwidth determines the screen columns of a single ucs_char_t.
> utf8_width returns the git_wcwidth of the first character in a string.
> utf8_strwidth (the function added by this patch) is a simple loop around
> utf8_width, because writing the loop every time would be silly.
Urgh. Sorry. If I had taken 3 seconds to actually _look_ at your patch,
I would have seen that (instead I thought "don't we already have
something that does this" and went straight to the existing code).
But no, it looks like we don't already have this, so your patch is fine.
Sorry for the noise.
-Peff
prev parent reply other threads:[~2009-01-31 8:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 9:41 [PATCH] utf8: add utf8_strwidth() Geoffrey Thomas
2009-01-30 9:41 ` [PATCH] builtin-blame.c: Use utf8_strwidth for author's names Geoffrey Thomas
2009-01-30 17:12 ` Johannes Schindelin
2009-01-30 22:22 ` Geoffrey Thomas
2009-01-31 7:24 ` Jeff King
2009-02-01 22:34 ` Johannes Schindelin
2009-02-02 6:48 ` Junio C Hamano
2009-02-02 12:40 ` Johannes Schindelin
2009-02-03 4:30 ` Junio C Hamano
2009-02-02 12:41 ` Jeff King
2009-01-31 7:17 ` [PATCH] utf8: add utf8_strwidth() Jeff King
2009-01-31 8:51 ` Geoffrey Thomas
2009-01-31 8:56 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090131085652.GA6484@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=geofft@MIT.EDU \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).