From: Robin Rosenberg <robin.rosenberg@dewire.com>
To: Yann Simon <yann.simon.fr@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH JGIT] fix typo
Date: Sat, 31 Jan 2009 17:45:16 +0100 [thread overview]
Message-ID: <200901311745.16803.robin.rosenberg@dewire.com> (raw)
In-Reply-To: <1233411967.8213.4.camel@localhost>
lördag 31 januari 2009 15:26:07 skrev Yann Simon:
> fix a little typo
> Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
> ---
> .../src/org/spearce/jgit/lib/WindowedFile.java | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Cleanups are nice too, but please try to follow the existing
style when it comes to comments. I don't think we have
stated these implicit rules anywhere.
- New sentences start with a capital letter.
- Don't repeat yourself You do not need a body in the comment
if the first line says it all, except the SOB line which technically
is part of the body.
- Make sure there is an empty line before the SOB line.
Cheers,
-- robin
next prev parent reply other threads:[~2009-01-31 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 14:26 [PATCH JGIT] fix typo Yann Simon
2009-01-31 16:45 ` Robin Rosenberg [this message]
2009-02-01 12:42 ` Baz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901311745.16803.robin.rosenberg@dewire.com \
--to=robin.rosenberg@dewire.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
--cc=yann.simon.fr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).