From: Jeff King <peff@peff.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, "Suraj N. Kurapati" <sunaku@gmail.com>
Subject: Re: [RFC PATCH] add -p: prompt for single characters
Date: Mon, 2 Feb 2009 08:19:00 -0500 [thread overview]
Message-ID: <20090202131900.GC8487@sigio.peff.net> (raw)
In-Reply-To: <1233520511-13061-1-git-send-email-trast@student.ethz.ch>
On Sun, Feb 01, 2009 at 09:35:11PM +0100, Thomas Rast wrote:
> I wrote this on the train today, but it turns out a similar idea was
> already around earlier:
>
> http://thread.gmane.org/gmane.comp.version-control.git/100146
>
> I can't find the v4 promised there, so I assume Suraj dropped it.
It looks like you addressed the concerns I had with the original. I do
think, as Junio mentioned, that it makes sense for this to be
configurable. Because it's interactive by defintion, I don't know if we
have the same compatibility concerns that we usually do. So I'm not sure
if such a config option should default to off or on.
-Peff
prev parent reply other threads:[~2009-02-02 13:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 20:35 [RFC PATCH] add -p: prompt for single characters Thomas Rast
2009-02-02 3:31 ` Suraj Kurapati
2009-02-02 8:34 ` Thomas Rast
2009-02-02 8:50 ` Junio C Hamano
2009-02-02 21:46 ` [PATCH 0/4] add -p: Term::ReadKey and more Thomas Rast
2009-02-02 21:46 ` [PATCH 1/4] add -p: change prompt separator for 'g' Thomas Rast
2009-02-02 21:46 ` [PATCH 2/4] add -p: trap Ctrl-D in 'goto' mode Thomas Rast
2009-02-02 21:46 ` [PATCH 3/4] add -p: optionally prompt for single characters Thomas Rast
2009-02-03 6:24 ` Jeff King
2009-02-03 8:54 ` [Illustration PATCH] add -i: accept single-keypress input Thomas Rast
2009-02-03 9:05 ` Junio C Hamano
2009-02-03 9:35 ` Thomas Rast
2009-02-04 5:10 ` Junio C Hamano
2009-02-04 8:51 ` Thomas Rast
2009-02-04 19:42 ` [PATCH 3/4] add -p: optionally prompt for single characters Thomas Rast
2009-02-04 20:08 ` [PATCH v2 3/4] add -p: " Thomas Rast
2009-02-04 20:08 ` [PATCH v2 4/4] add -p: print errors in separate color Thomas Rast
2009-02-04 20:12 ` [PATCH v3 3/4] add -p: prompt for single characters Thomas Rast
2009-02-04 20:12 ` [PATCH v3 4/4] add -p: print errors in separate color Thomas Rast
2009-02-04 20:40 ` [PATCH 3/4] add -p: optionally prompt for single characters Junio C Hamano
2009-02-05 8:28 ` [PATCH v4 3/4] add -p: " Thomas Rast
2009-02-06 14:01 ` Jeff King
2009-02-06 19:30 ` [PATCH] add -p: import Term::ReadKey with 'require' Thomas Rast
2009-02-06 20:30 ` Jeff King
2009-02-06 23:21 ` Thomas Rast
2009-02-07 4:54 ` Jeff King
2009-02-07 7:50 ` Junio C Hamano
2009-02-05 8:28 ` [PATCH v4 4/4] add -p: print errors in separate color Thomas Rast
2009-02-02 21:46 ` [PATCH 4/4] add -p: print errors in help colors Thomas Rast
2009-02-02 13:19 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202131900.GC8487@sigio.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunaku@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).